From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH] kvmtool Makefile: relax arm test Date: Fri, 4 Sep 2015 12:06:47 +0100 Message-ID: <55E97B47.7050100@arm.com> References: <1441279212-8797-1-git-send-email-riku.voipio@linaro.org> <55E96E23.2090802@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" To: Riku Voipio Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:37093 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963AbbIDLF3 (ORCPT ); Fri, 4 Sep 2015 07:05:29 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Hi Riku, On 04/09/15 11:52, Riku Voipio wrote: > On 4 September 2015 at 13:10, Andre Przywara wrote: >> Hi Riku, >> >> On 03/09/15 12:20, riku.voipio@linaro.org wrote: >>> From: Riku Voipio >>> >>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit >>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails. >>> We expect doing 32bit arm builds in Aarch64 to become standard the same way >>> people do i386 builds on x86_64 machines. >>> >>> Make the sed test a little more greedy so armv8l becomes acceptable. >>> >>> Signed-off-by: Riku Voipio >> >> The patch looks OK to me, I just wonder how you do the actual build >> within the linux32 environment? >> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is >> there a magic compiler (driver) which uses uname -m as well? >> And what would be the difference to setting ARCH=arm as well? Just >> convenience? > > It's just an arm32 chroot, with an native arm32 compiler. The chroot > is on an arm64 machine since these tend to be much faster than arm32 > hardware. Oh right, a chroot, didn't think about the obvious ;-) Also it applies to 64-bit kernels with 32-bit root filesystems, I think. So: Acked-by: Andre Przywara Cheers, Andre. > > It would of course be possible to set ARCH=arm, but that would mean > some ifdefs in the Debian packaging, since the same build rule should > work for all architectures. > > Riku >