From: Michal Marek <mmarek@suse.cz>
To: Behan Webster <behanw@converseincode.com>,
Anton Blanchard <anton@samba.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
linux-kbuild@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling
Date: Fri, 4 Sep 2015 13:25:19 +0200 [thread overview]
Message-ID: <55E97F9F.30300@suse.cz> (raw)
In-Reply-To: <55DECC61.60705@suse.cz>
On 2015-08-27 10:37, Michal Marek wrote:
> On 2015-08-27 03:49, Behan Webster wrote:
>> Is there any reason you renamed COMPILER? Because it breaks all the
>> other patches we have queued up which use it for cross compiling.
>>
>> And aren't we supposed to use all caps for variable names?
>
> It more like a function now and is consistent with the other cc-*
> definitions in scripts/Kbuild.include.
>
>
>> This doesn't only break powerpc, it breaks arm, aarch64 and clang work
>> that's being done on MIPS malta.
>
> So do a s/COMPILER/cc-name/ ? You can merge my patch into your tree to
> avoid a dependency on the kbuild tree.
Since I haven't seen any further uses of the $(CLANG) variable in
linux-next, I applied the patch to kbuild.git now.
Michal
prev parent reply other threads:[~2015-09-04 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 21:35 [PATCH v2] Makefile: Fix detection of clang when cross-compiling Paul Cercueil
2015-04-22 14:33 ` Michal Marek
2015-07-09 23:09 ` Behan Webster
2015-07-13 10:59 ` Anton Blanchard
2015-08-19 15:41 ` Michal Marek
2015-08-19 15:41 ` Michal Marek
2015-08-27 1:49 ` Behan Webster
2015-08-27 8:37 ` Michal Marek
2015-09-04 11:25 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E97F9F.30300@suse.cz \
--to=mmarek@suse.cz \
--cc=anton@samba.org \
--cc=behanw@converseincode.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.