From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759567AbbIDNwz (ORCPT ); Fri, 4 Sep 2015 09:52:55 -0400 Received: from smtp.citrix.com ([66.165.176.89]:56755 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758485AbbIDNwu (ORCPT ); Fri, 4 Sep 2015 09:52:50 -0400 X-IronPort-AV: E=Sophos;i="5.17,469,1437436800"; d="scan'208";a="297697726" Message-ID: <55E9A1CE.9090905@citrix.com> Date: Fri, 4 Sep 2015 14:51:10 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Roger Pau Monne , CC: David Vrabel , , Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection References: <1441361287-41234-1-git-send-email-roger.pau@citrix.com> In-Reply-To: <1441361287-41234-1-git-send-email-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On 04/09/15 11:08, Roger Pau Monne wrote: > Request allocation has been moved to connect_ring, which is called every > time blkback connects to the frontend (this can happen multiple times during > a blkback instance life cycle). On the other hand, request freeing has not > been moved, so it's only called when destroying the backend instance. Due to > this mismatch, blkback can allocate the request pool multiple times, without > freeing it. > > In order to fix it, move the freeing of requests to xen_blkif_disconnect to > restore the symmetry between request allocation and freeing. > > Reported-by: Julien Grall > Signed-off-by: Roger Pau Monné > Cc: Julien Grall > Cc: Konrad Rzeszutek Wilk > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: xen-devel@lists.xenproject.org The patch is fixing my problem when using UEFI in the guest. Thank you! Tested-by: Julien Grall Regards, -- Julien Grall