From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXrXE-0003Wv-Ax for qemu-devel@nongnu.org; Fri, 04 Sep 2015 10:00:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXrX8-0005eU-PU for qemu-devel@nongnu.org; Fri, 04 Sep 2015 10:00:08 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:57460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXrX8-0005du-K4 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 10:00:02 -0400 References: <1441239463-18981-1-git-send-email-rth@twiddle.net> <1441239463-18981-10-git-send-email-rth@twiddle.net> From: Bastian Koppelmann Message-ID: <55E9A3DF.2010606@mail.uni-paderborn.de> Date: Fri, 4 Sep 2015 15:59:59 +0200 MIME-Version: 1.0 In-Reply-To: <1441239463-18981-10-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/17] target-openrisc: Implement ff1 and fl1 for 64-bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, proljc@gmail.com On 09/03/2015 02:17 AM, Richard Henderson wrote: > True, this is unused so far, but commented out is worse than > actually implemented properly. > > Signed-off-by: Richard Henderson > --- > target-openrisc/int_helper.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > Reviewed-by: Bastian Koppelmann