From: Jeremy Linton <jeremy.linton@arm.com>
To: Julien Grall <julien.grall@citrix.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] device property: Don't overwrite addr when failing in device_get_mac_address
Date: Fri, 4 Sep 2015 09:03:00 -0500 [thread overview]
Message-ID: <55E9A494.5000108@arm.com> (raw)
In-Reply-To: <1441321190-25631-1-git-send-email-julien.grall@citrix.com>
On 09/03/2015 05:59 PM, Julien Grall wrote:
> The function device_get_mac_address is trying different property names
> in order to get the mac address. To check the return value, the variable
> addr (which contain the buffer pass by the caller) will be re-used. This
> means that if the previous property is not found, the next property will
> be read using a NULL buffer.
Thanks for catching that! I checked the OF version to see if it has the
same problem, but of course it doesn't because I added the logic to pass
the buffer into the routine.
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
next prev parent reply other threads:[~2015-09-04 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 22:59 [PATCH] device property: Don't overwrite addr when failing in device_get_mac_address Julien Grall
2015-09-04 14:03 ` Jeremy Linton [this message]
2015-09-08 20:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E9A494.5000108@arm.com \
--to=jeremy.linton@arm.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=julien.grall@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.