From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for 4.6 2/5] libxc: migration v2 prefix Memory -> Memory (P2M)
Date: Fri, 4 Sep 2015 21:40:55 +0100 [thread overview]
Message-ID: <55EA01D7.803@citrix.com> (raw)
In-Reply-To: <1441391531-30004-3-git-send-email-wei.liu2@citrix.com>
On 04/09/15 19:32, Wei Liu wrote:
> The prefix "Memory" is confusing because the numbers shown after that
> are referring to P2M entries. They have no bearing on how many pages a
> domain actually owns or how many actual pages are processed.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/libxc/xc_sr_save.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
> index 58667af..bb7ff54 100644
> --- a/tools/libxc/xc_sr_save.c
> +++ b/tools/libxc/xc_sr_save.c
> @@ -659,7 +659,7 @@ static int send_domain_memory_nonlive(struct xc_sr_context *ctx)
> if ( rc )
> goto err;
>
> - xc_set_progress_prefix(xch, "Memory");
> + xc_set_progress_prefix(xch, "Memory (P2M)");
This is incorrect for autotranslated guests. I would recommend "Frames"
instead.
~Andrew
next prev parent reply other threads:[~2015-09-04 20:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 18:32 [PATCH for 4.6 0/5] Migration v2 fix Wei Liu
2015-09-04 18:32 ` [PATCH for 4.6 1/5] libxc: clearer migration v2 debug message Wei Liu
2015-09-04 20:39 ` Andrew Cooper
2015-09-04 18:32 ` [PATCH for 4.6 2/5] libxc: migration v2 prefix Memory -> Memory (P2M) Wei Liu
2015-09-04 20:40 ` Andrew Cooper [this message]
2015-09-04 20:50 ` Wei Liu
2015-09-04 18:32 ` [PATCH for 4.6 3/5] libxc: fix indentation Wei Liu
2015-09-04 20:41 ` Andrew Cooper
2015-09-04 18:32 ` [PATCH for 4.6 4/5] libxc: add assertion to avoid setting same bit more than once Wei Liu
2015-09-04 20:43 ` Andrew Cooper
2015-09-04 20:49 ` Wei Liu
2015-09-04 18:32 ` [PATCH for 4.6 5/5] libxc: de-duplicate gpfns in populate_pfns Wei Liu
2015-09-04 21:56 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EA01D7.803@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.