From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH v1 3/8] btrfs: add .copy_file_range file operation Date: Fri, 4 Sep 2015 17:02:31 -0400 Message-ID: <55EA06E7.9060306@fb.com> References: <1441397823-1203-1-git-send-email-Anna.Schumaker@Netapp.com> <1441397823-1203-4-git-send-email-Anna.Schumaker@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441397823-1203-4-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Anna Schumaker , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, clm-b10kYP2dOMg@public.gmane.org, darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org List-Id: linux-api@vger.kernel.org On 09/04/2015 04:16 PM, Anna Schumaker wrote: > From: Zach Brown > > This rearranges the existing COPY_RANGE ioctl implementation so that the > .copy_file_range file operation can call the core loop that copies file > data extent items. > > The extent copying loop is lifted up into its own function. It retains > the core btrfs error checks that should be shared. > > Signed-off-by: Zach Brown > Signed-off-by: Anna Schumaker This bit looks fine to me, Reviewed-by: Josef Bacik Thanks, Josef From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:11408 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933735AbbIDVDH (ORCPT ); Fri, 4 Sep 2015 17:03:07 -0400 Subject: Re: [PATCH v1 3/8] btrfs: add .copy_file_range file operation To: Anna Schumaker , , , , , , , , , , , References: <1441397823-1203-1-git-send-email-Anna.Schumaker@Netapp.com> <1441397823-1203-4-git-send-email-Anna.Schumaker@Netapp.com> From: Josef Bacik Message-ID: <55EA06E7.9060306@fb.com> Date: Fri, 4 Sep 2015 17:02:31 -0400 MIME-Version: 1.0 In-Reply-To: <1441397823-1203-4-git-send-email-Anna.Schumaker@Netapp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 09/04/2015 04:16 PM, Anna Schumaker wrote: > From: Zach Brown > > This rearranges the existing COPY_RANGE ioctl implementation so that the > .copy_file_range file operation can call the core loop that copies file > data extent items. > > The extent copying loop is lifted up into its own function. It retains > the core btrfs error checks that should be shared. > > Signed-off-by: Zach Brown > Signed-off-by: Anna Schumaker This bit looks fine to me, Reviewed-by: Josef Bacik Thanks, Josef From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH v1 3/8] btrfs: add .copy_file_range file operation Date: Fri, 4 Sep 2015 17:02:31 -0400 Message-ID: <55EA06E7.9060306@fb.com> References: <1441397823-1203-1-git-send-email-Anna.Schumaker@Netapp.com> <1441397823-1203-4-git-send-email-Anna.Schumaker@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit To: Anna Schumaker , , , , , , , , , , , Return-path: In-Reply-To: <1441397823-1203-4-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 09/04/2015 04:16 PM, Anna Schumaker wrote: > From: Zach Brown > > This rearranges the existing COPY_RANGE ioctl implementation so that the > .copy_file_range file operation can call the core loop that copies file > data extent items. > > The extent copying loop is lifted up into its own function. It retains > the core btrfs error checks that should be shared. > > Signed-off-by: Zach Brown > Signed-off-by: Anna Schumaker This bit looks fine to me, Reviewed-by: Josef Bacik Thanks, Josef