From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v6 11/29] xen/x86: add bitmap of enabled
	emulated devices
Date: Fri, 4 Sep 2015 23:41:57 +0100
Message-ID: <55EA1E35.3030104@citrix.com>
References: <1441368548-43465-1-git-send-email-roger.pau@citrix.com>
	<1441368548-43465-12-git-send-email-roger.pau@citrix.com>
	<20150904122537.GC27133@zion.uk.xensource.com>
	<55E9A1D5.7080302@citrix.com>
	<55E9BEE6020000780009FC4A@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <amc96@hermes.cam.ac.uk>) id 1ZXzgI-0001jb-EJ
	for xen-devel@lists.xenproject.org; Fri, 04 Sep 2015 22:42:02 +0000
In-Reply-To: <55E9BEE6020000780009FC4A@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/09/15 14:55, Jan Beulich wrote:
>>>> On 04.09.15 at 15:51, <roger.pau@citrix.com> wrote:
>> El 04/09/15 a les 14.25, Wei Liu ha escrit:
>>> On Fri, Sep 04, 2015 at 02:08:50PM +0200, Roger Pau Monne wrote:
>>>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
>>>> index 045f6ff..fe9504f 100644
>>>> --- a/xen/arch/x86/domain.c
>>>> +++ b/xen/arch/x86/domain.c
>>>> @@ -555,6 +555,29 @@ int arch_domain_create(struct domain *d, unsigned int
>> domcr_flags,
>>>>                  d->domain_id);
>>>>       }
>>>>   
>>>> +    if ( is_hvm_domain(d) )
>>>> +    {
>>>> +        uint32_t emulation_mask = (XEN_X86_EMU_LAPIC | XEN_X86_EMU_HPET |
>>>> +                                   XEN_X86_EMU_PMTIMER | XEN_X86_EMU_RTC |
>>>> +                                   XEN_X86_EMU_IOAPIC | XEN_X86_EMU_PIC |
>>>> +                                   XEN_X86_EMU_PMU | XEN_X86_EMU_VGA |
>>>> +                                   XEN_X86_EMU_IOMMU);
>>> This is repetitive. Could you consolidate all these to
>>>
>>>    #define XEN_X86_EMU_ALL ...
>>>
>>> ?
>> That sounds fine, I would place it in the public header where all the
>> XEN_X86_EMU_* are defined. I will wait for Andrew's opinion, since he
>> already acked this patch.
> This doesn't belong in the public ABI, so if at all it should be added
> there inside #ifdef __XEN__. Alternatively (and perhaps preferably)
> this would go into another (internal) header.

Agreed.

Having an ALL mask will be useful for checking invalid values, but this 
logic is going to get a bit more complicated as soon as we see about 
introducing situations which permit the use of the vLAPIC, and I don't 
see the ALL mask being useful anywhere else.

I am not fussed either way.

~Andrew