From: Clint Taylor <clinton.a.taylor@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/i915: don't hard code vlv backlight frequency if unset
Date: Fri, 04 Sep 2015 15:42:54 -0700 [thread overview]
Message-ID: <55EA1E6E.2020703@intel.com> (raw)
In-Reply-To: <1441374915-14076-3-git-send-email-jani.nikula@intel.com>
On 09/04/2015 06:55 AM, Jani Nikula wrote:
> Fall back to VBT based backlight modulation frequency if it's not
> set. Do not hard code.
>
> This could be a problem if there is no VBT.
>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_panel.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index d3a312c409eb..2034438a0664 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1532,21 +1532,8 @@ static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipe
> struct drm_device *dev = connector->base.dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_panel *panel = &connector->panel;
> - enum pipe p;
> u32 ctl, ctl2, val;
>
> - for_each_pipe(dev_priv, p) {
> - u32 cur_val = I915_READ(VLV_BLC_PWM_CTL(p));
> -
> - /* Skip if the modulation freq is already set */
> - if (cur_val & ~BACKLIGHT_DUTY_CYCLE_MASK)
> - continue;
> -
> - cur_val &= BACKLIGHT_DUTY_CYCLE_MASK;
> - I915_WRITE(VLV_BLC_PWM_CTL(p), (0xf42 << 16) |
> - cur_val);
> - }
> -
> if (WARN_ON(pipe != PIPE_A && pipe != PIPE_B))
> return -ENODEV;
>
>
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>
Tested-by: Clint Taylor <Clinton.A.Taylor@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-04 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 13:55 [PATCH v2 1/3] drm/i915: use pch backlight override on hsw too Jani Nikula
2015-09-04 13:55 ` [PATCH v2 2/3] drm/i915: initialize backlight max from VBT Jani Nikula
2015-09-04 22:42 ` Clint Taylor
2015-09-04 13:55 ` [PATCH v2 3/3] drm/i915: don't hard code vlv backlight frequency if unset Jani Nikula
2015-09-04 22:42 ` Clint Taylor [this message]
2015-09-07 16:30 ` Daniel Vetter
2015-09-04 22:38 ` [PATCH v2 1/3] drm/i915: use pch backlight override on hsw too Clint Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EA1E6E.2020703@intel.com \
--to=clinton.a.taylor@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.