Re: [Devel] PATCH proposal removing use of strtoul in events/evgpeinit.c

[Richard PALO <richard at netbsd.org>]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Le 04/09/15 15:58, Moore, Robert a écrit :
> Sure, but the original code is much simpler.
> 
 
The reason for the error was that, by default, the extern declaration was forcluded by
_DDI_STRICT being defined.. 
which is to say that strtoul, strictly speaking is unavailable in the Solaris kernel (excepting kmdb).

So I kludged and added to acsolaris.h #ifdef _KERNEL section :
> static __GNU_INLINE unsigned long
> strtoul(const char *str, char **nptr, int base)
> {
> 	unsigned long ret;
> 	int status;
> 
> 	if ((status = ddi_strtoul(str, nptr, base, &ret)) != 0) {
> 		if (status == ERANGE)
> 			return (ULONG_MAX);
> 		return (0);
> 	}
> 	return (ret);
> }

Still seems for one call in the kernel to convert a single HEX byte from ascii to unsigned long, that 
the portable solution is to avoid using 'strtoul' in paths operating in kernel space.
(also considering the Linux discussion also around strtoul in the kernel)

cheers,
-- 
Richard PALO