From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 832CB7404E for ; Sun, 6 Sep 2015 05:46:19 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id t865kKAE022594 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL) for ; Sat, 5 Sep 2015 22:46:20 -0700 (PDT) Received: from [128.224.162.158] (128.224.162.158) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.235.1; Sat, 5 Sep 2015 22:46:19 -0700 Message-ID: <55EBD32A.90200@windriver.com> Date: Sun, 6 Sep 2015 13:46:18 +0800 From: Rongqing Li User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: References: <1439426312-26368-1-git-send-email-rongqing.li@windriver.com> <55D5855F.8030703@windriver.com> <55DFC1A6.1060806@windriver.com> In-Reply-To: <55DFC1A6.1060806@windriver.com> Subject: Re: [PATCH][meta-networking][v2] ypbind-mt: add status command for initscript X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Sep 2015 05:46:20 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit after dropping the patch [Re: [oe] [PATCH 1/2] ypbind-mt: get parameters from dhcp], this patch should be able to applied to master-next. thanks -Roy On 2015年08月28日 10:04, Rongqing Li wrote: > ping > > -Roy > > On 2015年08月20日 15:44, Rongqing Li wrote: >> Could we drop the first version of this patch from master-next, >> {[a314ab41a] ypbind-yocto.init: add status command} >> >> >> and accept this one >> >> thanks >> >> -Roy >> >> On 2015年08月13日 08:38, rongqing.li@windriver.com wrote: >>> From: Zhu Yanjun >>> >>> Add the "status" command in initscript to check the status of ypbind. >>> remove ypbind-yocto.init as ypbind.init, which is the initscript, make >>> its name similar to other recipes >>> >>> Signed-off-by: Zhu Yanjun >>> Signed-off-by: Roy Li >>> --- >>> .../recipes-support/nis/files/{ypbind-yocto.init => ypbind.init} | >>> 7 +++++++ >>> meta-networking/recipes-support/nis/ypbind-mt_1.38.bb | >>> 4 ++-- >>> meta-networking/recipes-support/nis/ypbind-mt_2.2.bb | >>> 4 ++-- >>> 3 files changed, 11 insertions(+), 4 deletions(-) >>> rename meta-networking/recipes-support/nis/files/{ypbind-yocto.init >>> => ypbind.init} (96%) >>> >>> diff --git >>> a/meta-networking/recipes-support/nis/files/ypbind-yocto.init >>> b/meta-networking/recipes-support/nis/files/ypbind.init >>> similarity index 96% >>> rename from meta-networking/recipes-support/nis/files/ypbind-yocto.init >>> rename to meta-networking/recipes-support/nis/files/ypbind.init >>> index 2c50d12..244dc78 100644 >>> --- a/meta-networking/recipes-support/nis/files/ypbind-yocto.init >>> +++ b/meta-networking/recipes-support/nis/files/ypbind.init >>> @@ -21,6 +21,9 @@ >>> # the NIS binding information. >>> ### END INIT INFO >>> >>> +# Need to use status function >>> +. /etc/init.d/functions >>> + >>> YPBIND_BIN=/usr/sbin/ypbind >>> pidfile=/var/run/ypbind.pid >>> >>> @@ -92,6 +95,10 @@ case "$1" in >>> echo -n "Reload service ypbind" >>> start-stop-daemon --stop --quiet --signal 1 --pidfile $pidfile >>> ;; >>> + status) >>> + echo -n "Checking for ypbind: " >>> + status $YPBIND_BIN >>> + ;; >>> *) >>> echo "Usage: $0 >>> {start|stop|status|try-restart|restart|force-reload|reload|probe}" >>> exit 1 >>> diff --git a/meta-networking/recipes-support/nis/ypbind-mt_1.38.bb >>> b/meta-networking/recipes-support/nis/ypbind-mt_1.38.bb >>> index d25ef5c..5702cd6 100644 >>> --- a/meta-networking/recipes-support/nis/ypbind-mt_1.38.bb >>> +++ b/meta-networking/recipes-support/nis/ypbind-mt_1.38.bb >>> @@ -26,7 +26,7 @@ DEPENDS = " \ >>> PROVIDES += "ypbind" >>> >>> SRC_URI = "http://www.linux-nis.org/download/ypbind-mt/${BP}.tar.bz2 \ >>> - file://ypbind-yocto.init \ >>> + file://ypbind.init \ >>> file://ypbind.service \ >>> " >>> SRC_URI[md5sum] = "094088c0e282fa7f3b3dd6cc51d0a4e1" >>> @@ -44,7 +44,7 @@ do_install_append () { >>> install -d ${D}${sysconfdir}/init.d >>> install -d ${D}${sysconfdir}/rcS.d >>> >>> - install -m 0755 ${WORKDIR}/ypbind-yocto.init >>> ${D}${sysconfdir}/init.d/ypbind >>> + install -m 0755 ${WORKDIR}/ypbind.init >>> ${D}${sysconfdir}/init.d/ypbind >>> >>> install -d ${D}${systemd_unitdir}/system >>> install -m 0644 ${WORKDIR}/ypbind.service >>> ${D}${systemd_unitdir}/system >>> diff --git a/meta-networking/recipes-support/nis/ypbind-mt_2.2.bb >>> b/meta-networking/recipes-support/nis/ypbind-mt_2.2.bb >>> index 6a9262a..cee5880 100644 >>> --- a/meta-networking/recipes-support/nis/ypbind-mt_2.2.bb >>> +++ b/meta-networking/recipes-support/nis/ypbind-mt_2.2.bb >>> @@ -21,7 +21,7 @@ PROVIDES += "ypbind" >>> PNBLACKLIST[ypbind-mt] ?= "BROKEN: Depends on broken yp-tools" >>> >>> SRC_URI = "http://www.linux-nis.org/download/ypbind-mt/${BP}.tar.bz2 \ >>> - file://ypbind-yocto.init \ >>> + file://ypbind.init \ >>> file://ypbind.service \ >>> " >>> SRC_URI[md5sum] = "54e2040d8266ae7d302d081ca310c8a8" >>> @@ -41,7 +41,7 @@ do_install_append () { >>> install -d ${D}${sysconfdir}/init.d >>> install -d ${D}${sysconfdir}/rcS.d >>> >>> - install -m 0755 ${WORKDIR}/ypbind-yocto.init >>> ${D}${sysconfdir}/init.d/ypbind >>> + install -m 0755 ${WORKDIR}/ypbind.init >>> ${D}${sysconfdir}/init.d/ypbind >>> >>> install -d ${D}${systemd_unitdir}/system >>> install -m 0644 ${WORKDIR}/ypbind.service >>> ${D}${systemd_unitdir}/system >>> >> > -- Best Reagrds, Roy | RongQing Li