From: "H. Peter Anvin" <hpa@zytor.com>
To: Nikolay Borisov <nikolay.b.borisov@gmail.com>, mingo@kernel.org
Cc: dvlasenk@redhat.com, luto@amacapital.net,
linux-kernel@vger.kernel.org, bp@suse.de
Subject: Re: [PATCH v2] x86/asm/entry/64: Minor cleanup of conditional compilation
Date: Sat, 5 Sep 2015 23:03:00 -0700 [thread overview]
Message-ID: <55EBD714.30509@zytor.com> (raw)
In-Reply-To: <1441486423-6997-1-git-send-email-nikolay.b.borisov@gmail.com>
On 09/05/15 13:53, Nikolay Borisov wrote:
> The entry_SYSCALL_64_fastpath was checking the value of __SYSCALL_MASK,
> which in turn was being set in arch/x86/include/asm/unistd.h depending on
> whether CONFIG_X86_X32_ABI was set or not. This made the intention a bit
> cryptic.
On the contrary: that instruction can be omitted if and only if the
value of the mask is all 1's; it doesn't matter how the mask is set. So
you just turned a local constraint into a global constraint. This is
both unnecessarily confusing and opens the risk for bugs later.
If you feel the need, you could submit a patch to add a comment, but
this version is:
Nacked-by: H. Peter Anvin <hpa@zytor.com>
prev parent reply other threads:[~2015-09-06 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 20:53 [PATCH v2] x86/asm/entry/64: Minor cleanup of conditional compilation Nikolay Borisov
2015-09-06 6:03 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EBD714.30509@zytor.com \
--to=hpa@zytor.com \
--cc=bp@suse.de \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=nikolay.b.borisov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.