All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Duncan <lduncan@suse.com>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>,
	linux-scsi <linux-scsi@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	hare@suse.com, jthumshirn@suse.de, JBottomley@Parallels.com
Subject: Re: [PATCH 0/1] Update scsi hosts to use idr for host number mgmt
Date: Sun, 6 Sep 2015 08:12:23 -0700	[thread overview]
Message-ID: <55EC57D7.8040106@suse.com> (raw)
In-Reply-To: <55EBEC12.9030904@dev.mellanox.co.il>

On 09/06/2015 12:32 AM, Sagi Grimberg wrote:
> On 9/5/2015 11:44 PM, Lee Duncan wrote:
>> This is an updated version of a patch I submitted a few days ago.
>>
>> The previous versions of this patch updated the scsi hosts module
>> to use the ida helper routines to allocate host numbers, instead
>> of using a simple integer.
>>
>> Based on a suggestion by Christoph Hellwig, I decided to use the
>> idr helper routines instead of the ida set, since the idr functions
>> can also associate a pointer with an index.
> 
> While we're at it, why not include sd index conversion?
> 

I'm not sure what you mean here.

Are you suggesting sd.c be updated to use idr index routines instead of
ida routines so that sd.c could associate instance pointers with
instance numbers, much like I did for hosts.c?

If so, looking over sd.c, I don't think that would be feasible. The sd.c
driver does not do any searches for a pointer based on the index number.
Could you be more specific?

And do you have any objections to this patch?
-- 
Lee Duncan


      reply	other threads:[~2015-09-06 15:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-05 20:44 [PATCH 0/1] Update scsi hosts to use idr for host number mgmt Lee Duncan
2015-09-05 20:44 ` [PATCH 1/1] " Lee Duncan
2015-09-06  7:34   ` Sagi Grimberg
2015-09-06 15:16     ` Lee Duncan
2015-09-10  1:31       ` Lee Duncan
2015-09-06  7:32 ` [PATCH 0/1] " Sagi Grimberg
2015-09-06 15:12   ` Lee Duncan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EC57D7.8040106@suse.com \
    --to=lduncan@suse.com \
    --cc=JBottomley@Parallels.com \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sagig@dev.mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.