From: Loic Dachary <loic@dachary.org>
To: Abhishek L <abhishek.lekshmanan@gmail.com>,
Abhishek Varshney <abhishek.varshney@flipkart.com>,
Nathan Cutler <ncutler@suse.cz>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: [Backport] assigning a pull request when asking permission to merge
Date: Sun, 06 Sep 2015 23:47:13 +0200 [thread overview]
Message-ID: <55ECB461.6020805@dachary.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
Hi,
Today I realized that when we ask for permission to merge [1], we don't usually assign the pull request to the person who is supposed to answer. This may not be of consequence if thre is just one pull request to look at. But it's not uncommon to have half a dozen such pull requests after a suite passed. When the person reads her/his mail, a few are addressed and more often than not the rest is postponed for when there is time.
Only they don't show up anywhere in the person list of TODO things, therefore it's frequent that we have to send a reminder. Instead, it's probably easier on everyone if we assign the pull request to the person next to act in that specific case. It's not something I usually do for pull requests that are assigned to me, because it's the best way for me to completely forget about such pull requests. But in this case, since each pull request is linked to an issue and since we scrub these issues at least on a weekly basis, there is no risk of us forgetting.
What do you think ?
Cheers
P.S. I did that for all pending hammer pull requests, we'll see if that improves things ;-)
[1] http://tracker.ceph.com/projects/ceph-releases/wiki/HOWTO_merge_commits_from_the_integration_branch
---
Loïc Dachary, Artisan Logiciel Libre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2015-09-06 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 21:47 Loic Dachary [this message]
2015-09-07 7:19 ` [Backport] assigning a pull request when asking permission to merge Nathan Cutler
2015-09-08 13:30 ` Gregory Farnum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ECB461.6020805@dachary.org \
--to=loic@dachary.org \
--cc=abhishek.lekshmanan@gmail.com \
--cc=abhishek.varshney@flipkart.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ncutler@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.