From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752301AbbIGGH7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Sep 2015 02:07:59 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:28442 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750946AbbIGGH6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Sep 2015 02:07:58 -0400
Message-ID: <55ED29B3.3040805@oracle.com>
Date: Mon, 07 Sep 2015 14:07:47 +0800
From: Bob Liu <bob.liu@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4
MIME-Version: 1.0
To: Julien Grall <julien.grall@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection
References: <1441361287-41234-1-git-send-email-roger.pau@citrix.com> <55E9A1CE.9090905@citrix.com>
In-Reply-To: <55E9A1CE.9090905@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Julien,

On 09/04/2015 09:51 PM, Julien Grall wrote:
> Hi Roger,
> 
> On 04/09/15 11:08, Roger Pau Monne wrote:
>> Request allocation has been moved to connect_ring, which is called every
>> time blkback connects to the frontend (this can happen multiple times during
>> a blkback instance life cycle). On the other hand, request freeing has not
>> been moved, so it's only called when destroying the backend instance. Due to
>> this mismatch, blkback can allocate the request pool multiple times, without
>> freeing it.
>>
>> In order to fix it, move the freeing of requests to xen_blkif_disconnect to
>> restore the symmetry between request allocation and freeing.
>>
>> Reported-by: Julien Grall <julien.grall@citrix.com>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: Julien Grall <julien.grall@citrix.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: David Vrabel <david.vrabel@citrix.com>
>> Cc: xen-devel@lists.xenproject.org
> 
> The patch is fixing my problem when using UEFI in the guest. Thank you!
> 

Could you please explain the problem you met a bit more?
So that I can know back port this patch if met similar issue.

Thanks,
-Bob