From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: leds-ipaq-micro: Use devm_led_classdev_register
Date: Mon, 07 Sep 2015 09:53:19 +0200 [thread overview]
Message-ID: <55ED426F.9030109@samsung.com> (raw)
In-Reply-To: <1441482942-23447-1-git-send-email-falakreyaz@gmail.com>
Hi Muhammad,
Please split coding style fixes to a separate patch and leave
only devm related changes here.
On 09/05/2015 09:55 PM, Muhammad Falak R Wani wrote:
> Use of resource-managed function devm_led_classdev_register
> instead of led_classdev_register is preferred, consequently
> remove redundant function micro_leds_remove. Also some coding
> style issues are fixed, only two remain, which are left alone
> to aid better readability.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/leds/leds-ipaq-micro.c | 47 ++++++++++++++++++------------------------
> 1 file changed, 20 insertions(+), 27 deletions(-)
>
[...]
--
Best Regards,
Jacek Anaszewski
prev parent reply other threads:[~2015-09-07 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 19:55 [PATCH] leds: leds-ipaq-micro: Use devm_led_classdev_register Muhammad Falak R Wani
2015-09-07 7:53 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED426F.9030109@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=cooloney@gmail.com \
--cc=falakreyaz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.