From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 07 Sep 2015 11:33:56 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:39922 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006713AbbIGJdyucJaz (ORCPT ); Mon, 7 Sep 2015 11:33:54 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 71E4BD7A8BF84; Mon, 7 Sep 2015 10:33:46 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 7 Sep 2015 10:33:48 +0100 Received: from [192.168.154.88] (192.168.154.88) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Mon, 7 Sep 2015 10:33:48 +0100 Subject: Re: [PATCH 2/2 for-4.3] MIPS: BPF: Fix build on pre-R2 little endian CPUs To: Aurelien Jarno , References: <1441471618-5613-1-git-send-email-aurelien@aurel32.net> <1441471618-5613-2-git-send-email-aurelien@aurel32.net> CC: Ralf Baechle From: Markos Chandras Message-ID: <55ED59FC.4070505@imgtec.com> Date: Mon, 7 Sep 2015 10:33:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441471618-5613-2-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.88] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49119 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 09/05/2015 05:46 PM, Aurelien Jarno wrote: > The rotr, seh and wsbh instructions have been introduced with the R2 > ISA. Thus the current BPF code fails to build on pre-R2 little endian > CPUs: > > CC arch/mips/net/bpf_jit.o > AS arch/mips/net/bpf_jit_asm.o > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S: Assembler messages: > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:67: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:68: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:83: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:84: Error: opcode not supported on this processor: mips32 (mips32) `seh $19,$8' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:151: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$12' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:153: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:164: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $19,$12' > /home/aurel32/linux-4.2/scripts/Makefile.build:294: recipe for target 'arch/mips/net/bpf_jit_asm.o' failed > > Fix that by providing equivalent code for these CPUs. > > Cc: Ralf Baechle > Cc: Markos Chandras > Cc: stable@vger.kernel.org # v4.2+ > Signed-off-by: Aurelien Jarno > --- Reviewed-by: Markos Chandras -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:39922 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006713AbbIGJdyucJaz (ORCPT ); Mon, 7 Sep 2015 11:33:54 +0200 Subject: Re: [PATCH 2/2 for-4.3] MIPS: BPF: Fix build on pre-R2 little endian CPUs References: <1441471618-5613-1-git-send-email-aurelien@aurel32.net> <1441471618-5613-2-git-send-email-aurelien@aurel32.net> From: Markos Chandras Message-ID: <55ED59FC.4070505@imgtec.com> Date: Mon, 7 Sep 2015 10:33:48 +0100 MIME-Version: 1.0 In-Reply-To: <1441471618-5613-2-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Aurelien Jarno , linux-mips@linux-mips.org Cc: Ralf Baechle Message-ID: <20150907093348.YdchXvbdNUYKPqE4S9Jl9O47PtEOrCDErXuCvNKTut0@z> On 09/05/2015 05:46 PM, Aurelien Jarno wrote: > The rotr, seh and wsbh instructions have been introduced with the R2 > ISA. Thus the current BPF code fails to build on pre-R2 little endian > CPUs: > > CC arch/mips/net/bpf_jit.o > AS arch/mips/net/bpf_jit_asm.o > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S: Assembler messages: > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:67: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:68: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:83: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:84: Error: opcode not supported on this processor: mips32 (mips32) `seh $19,$8' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:151: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$12' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:153: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16' > /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:164: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $19,$12' > /home/aurel32/linux-4.2/scripts/Makefile.build:294: recipe for target 'arch/mips/net/bpf_jit_asm.o' failed > > Fix that by providing equivalent code for these CPUs. > > Cc: Ralf Baechle > Cc: Markos Chandras > Cc: stable@vger.kernel.org # v4.2+ > Signed-off-by: Aurelien Jarno > --- Reviewed-by: Markos Chandras -- markos