From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for 4.6 v3 0/5] Migration v2 fix Date: Mon, 7 Sep 2015 11:10:24 +0100 Message-ID: <55ED6290.9070903@citrix.com> References: <1441569939-23562-1-git-send-email-wei.liu2@citrix.com> <55ED6129.1080605@citrix.com> <20150907100717.GB6436@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZYtNc-0000Ix-Ky for xen-devel@lists.xenproject.org; Mon, 07 Sep 2015 10:10:28 +0000 In-Reply-To: <20150907100717.GB6436@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 07/09/15 11:07, Wei Liu wrote: > On Mon, Sep 07, 2015 at 11:04:25AM +0100, Andrew Cooper wrote: >> On 06/09/15 21:05, Wei Liu wrote: >>> Wei Liu (5): >>> libxc: clearer migration v2 debug message >>> libxc: migration v2 prefix Memory -> Frames >>> libxc: fix indentation >>> libxc: don't populate same pfn more than once in populate_pfns >>> libxc: add assertion to avoid setting same bit more than once >>> >>> tools/libxc/xc_sr_restore.c | 7 ++++--- >>> tools/libxc/xc_sr_restore_x86_pv.c | 4 ++-- >>> tools/libxc/xc_sr_save.c | 10 +++++----- >>> 3 files changed, 11 insertions(+), 10 deletions(-) >>> >> Please test against Xen 4.5 as well. I have looked at the legacy code, but >> can't convince myself either way as to whether the bug is present or not. >> > DYM cross version migration from 4.5 to 4.6 or 32bit Linux 4.1 save / > restore with Xen 4.5? Just plain legacy migration with Linux 4.1, to see whether legacy suffers from the same issue. If it does, we should probably backport a legacy fix. ~Andrew