From: Paolo Bonzini <pbonzini@redhat.com>
To: "Salva Peiró" <speirofr@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] memory: Add function pointers checks to memory_region_read/write()
Date: Mon, 7 Sep 2015 12:27:48 +0200 [thread overview]
Message-ID: <55ED66A4.7060108@redhat.com> (raw)
In-Reply-To: <1441301843-7404-1-git-send-email-speirofr@gmail.com>
On 03/09/2015 19:37, Salva Peiró wrote:
> The file memory.c directly calls the function pointers provided in
> the MemoryRegionOps to handle read and write operations for memory regions.
> The function pointers are called without checking if the function
> pointers are initialised, therefore, causing QEMU to SIGSEGV when
> accessing a memory address for which the operation is not defined (and not initialised)
>
> The patch adds explicit checks to function pointers before issuing the calls.
What device are you encountering this for? Perhaps this should be done
in memory_region_init_io instead, so that it is detected early.
Paolo
next prev parent reply other threads:[~2015-09-07 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 17:37 [Qemu-devel] [PATCH] memory: Add function pointers checks to memory_region_read/write() Salva Peiró
2015-09-07 10:27 ` Paolo Bonzini [this message]
2015-09-08 6:51 ` Salva Peiró
2015-09-08 8:55 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2015-07-28 7:13 [Qemu-devel] " Salva Peiró
2015-07-28 7:13 ` [Qemu-devel] [PATCH] " Salva Peiró
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED66A4.7060108@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=speirofr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.