From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Mike Day <ncmike@ncultra.org>, Fam Zheng <famz@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change
Date: Mon, 7 Sep 2015 13:00:16 +0200 [thread overview]
Message-ID: <55ED6E40.2090907@redhat.com> (raw)
In-Reply-To: <1440666378-3152-1-git-send-email-mst@redhat.com>
On 27/08/2015 11:06, Michael S. Tsirkin wrote:
> commit 9b8424d5735278ca382f11adc7c63072b632ab83
> "exec: split length -> used_length/max_length"
> changed field names in struct RAMBlock
>
> It turns out that scripts/dump-guest-memory.py was
> poking at this field, update it accordingly.
>
> Cc: qemu-stable@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> scripts/dump-guest-memory.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index dc8e44a..08796ff 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -118,7 +118,7 @@ shape and this command should mostly work."""
> def qemu_get_ram_block(self, ram_addr):
> ram_blocks = gdb.parse_and_eval("ram_list.blocks")
> for block in self.qlist_foreach(ram_blocks, "next"):
> - if (ram_addr - block["offset"] < block["length"]):
> + if (ram_addr - block["offset"] < block["used_length"]):
> return block
> raise gdb.GdbError("Bad ram offset %x" % ram_addr)
>
>
Thanks, queued for my next pull request.
Paolo
prev parent reply other threads:[~2015-09-07 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 9:06 [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change Michael S. Tsirkin
2015-09-07 11:00 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED6E40.2090907@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=ncmike@ncultra.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.