From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 0/2] xen/arm: vgic: Support 32-bit access for 64-bit register Date: Mon, 7 Sep 2015 14:30:23 +0100 Message-ID: <55ED916F.4060202@citrix.com> References: <1438689599-24184-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZYwWG-0007uM-CS for xen-devel@lists.xenproject.org; Mon, 07 Sep 2015 13:31:36 +0000 In-Reply-To: <1438689599-24184-1-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: manish.jaggi@caviumnetworks.com, stefano.stabellini@citrix.com, ian.campbell@citrix.com, vijay.kilari@gmail.com, Vijaya.Kumar@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 04/08/15 12:59, Julien Grall wrote: > Hi all, Hi, Any more comments on this series before I send a new version? Regards, > This series aims to fix the 32-bit access on 64-bit register. Some guest > OS such as FreeBSD and Linux (only in the ITS) use those access and will > crash when starting on Xen. > > The first patch introduces generic helpers to read/write/clear/set a register. > While the second is the main purpose of this series. > > I'd like to go a bit further in the clean up, hence the RFC. But I wanted them > out in order to help Vijay supporting any access quickly for his ITS series. > > TODO: > - use the new helpers in vGICv2 > - support signed extension generically > - see what assembly is generated on 32-bit with the uint64_t cast. > It may be possible to optimize it a bit by avoid uint64_t. Although I'm > not sure if it's worth it. > > Sincerely yours, > > Julien Grall (2): > xen/arm: vgic: Introduce helpers to read/write/clear/set vGIC register > ... > xen/arm: vgic-v3: Support 32-bit access for 64-bit registers > > xen/arch/arm/vgic-v3.c | 126 +++++++++++++++++++++++++++++---------------- > xen/include/asm-arm/vgic.h | 104 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 187 insertions(+), 43 deletions(-) > -- Julien Grall