From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYx6G-00059Y-E0 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYx6D-0007t3-7k for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:08:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:46042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYx6D-0007sl-21 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:08:45 -0400 References: <1441383989-3377-1-git-send-email-jjherne@linux.vnet.ibm.com> <1441383989-3377-2-git-send-email-jjherne@linux.vnet.ibm.com> <55ED88B3.7090105@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <55ED9A6A.7040309@suse.de> Date: Mon, 7 Sep 2015 16:08:42 +0200 MIME-Version: 1.0 In-Reply-To: <55ED88B3.7090105@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 1/5] cpu: Provide vcpu throttling interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , quintela@redhat.com Cc: amit.shah@redhat.com, borntraeger@de.ibm.com, dgilbert@redhat.com, "Jason J. Herne" , qemu-devel@nongnu.org Am 07.09.2015 um 14:53 schrieb Paolo Bonzini: > On 04/09/2015 18:26, Jason J. Herne wrote: >> + pct =3D (double)cpu_throttle_get_percentage()/100; >> + throttle_ratio =3D pct / (1 - pct); >> + sleeptime_ms =3D (long)(throttle_ratio * CPU_THROTTLE_TIMESLICE); >=20 > This is going to be pretty imprecise, since there are only 11 possible > values of sleeptime_ms. Can you switch the timer and > CPU_THROTTLE_TIMESLICE to nanosecond precision instead? >=20 > It's okay to provide this as a patch 6/5, and the maintainer will squas= h > it into this patch. Alternatively this can be sent as v7, as you prefe= r. I'm assuming "the maintainer" refers to Juan for this series. ;) I've been waiting for you guys to reach consensus - only nit I have is that two colons are missing after "Returns" in the documentation. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)