From: "Andreas Färber" <afaerber@suse.de>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, ehabkost@redhat.com
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
Paolo Bonzini <pbonzini@redhat.com>,
imammedo@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] cpu: introduce CpuTopoInfo structure for argument simplification
Date: Mon, 7 Sep 2015 16:22:10 +0200 [thread overview]
Message-ID: <55ED9D92.5010506@suse.de> (raw)
In-Reply-To: <55ED7511.6020507@redhat.com>
Am 07.09.2015 um 13:29 schrieb Paolo Bonzini:
> On 21/08/2015 11:34, Zhu Guihua wrote:
>> @@ -107,14 +111,12 @@ static inline apic_id_t apicid_from_topo_ids(unsigned nr_cores,
>> static inline void x86_topo_ids_from_idx(unsigned nr_cores,
>> unsigned nr_threads,
>> unsigned cpu_index,
>> - unsigned *pkg_id,
>> - unsigned *core_id,
>> - unsigned *smt_id)
>> + X86CPUTopoInfo *topo)
>> {
>
> Isn't this function used in hw/i386/pc.c as well?
In case it gets respun now, in Seattle I had asked Eduardo to update the
subject with s/CpuTopoInfo/X86CPUTopoInfo/.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-09-07 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 9:34 [Qemu-devel] [PATCH] cpu: introduce CpuTopoInfo structure for argument simplification Zhu Guihua
2015-08-21 16:25 ` Eduardo Habkost
2015-09-07 11:29 ` Paolo Bonzini
2015-09-07 14:22 ` Andreas Färber [this message]
2015-09-09 16:11 ` Eduardo Habkost
2015-09-10 1:09 ` Zhu Guihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED9D92.5010506@suse.de \
--to=afaerber@suse.de \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.