From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: netback grant copying issues
Date: Mon, 7 Sep 2015 16:11:42 +0100 [thread overview]
Message-ID: <55EDA92E.2070701@citrix.com> (raw)
In-Reply-To: <55E9802E020000780009F90B@prv-mh.provo.novell.com>
On 04/09/15 10:27, Jan Beulich wrote:
> Ian, Wei,
>
> I seem to be seeing two issues in the grant copy handling of netback,
> solely from code inspection:
>
> 1) Shouldn't MAX_GRANT_COPY_OPS, to take care of the copying
> the header may require, be
> ((MAX_SKB_FRAGS + 1) * XEN_NETIF_RX_RING_SIZE)?
We really should have the copy batches be independent of ring size and
skb format.
e.g., Call xenvif_gnt_copy_add(ref, ptr, len) for each copy op needed.
This will issue the hypercall when the batch is full. There would need
to be axenvif_gnt_copy_flush() at the end for last hypercall for the
remaining ops.
David
prev parent reply other threads:[~2015-09-07 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 9:27 netback grant copying issues Jan Beulich
2015-09-07 14:47 ` Wei Liu
2015-09-07 15:03 ` Jan Beulich
2015-09-07 15:10 ` Wei Liu
2015-09-07 15:23 ` Jan Beulich
2015-09-07 15:40 ` Wei Liu
2015-09-07 15:11 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EDA92E.2070701@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.