From: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
To: "Chen, Yu C" <yu.c.chen@intel.com>
Cc: "kristen@linux.intel.com" <kristen@linux.intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Zhang, Rui" <rui.zhang@intel.com>
Subject: Re: [PATCH] intel_pstate: prevent max_perf_pct < min_perf_pct
Date: Tue, 8 Sep 2015 08:18:46 +0900 [thread overview]
Message-ID: <55EE1B56.3010205@jp.fujitsu.com> (raw)
In-Reply-To: <36DF59CE26D8EE47B0655C516E9CE6401CB04B52@SHSMSX101.ccr.corp.intel.com>
Hi, Yu
On 2015-09-07 18:00, Chen, Yu C wrote:
> Hi, Seiichi
>
>> -----Original Message-----
>> From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
>> owner@vger.kernel.org] On Behalf Of Seiichi Ikarashi
>> Sent: Friday, September 04, 2015 6:59 PM
>> To: kristen@linux.intel.com; Wysocki, Rafael J
>> Cc: linux-pm@vger.kernel.org
>> Subject: [PATCH] intel_pstate: prevent max_perf_pct < min_perf_pct
>>
>> Add some value check to prevent a reversal, max_perf_pct < min_perf_pct.
>>
>> Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
>>
> I guess a similar patch has been sent at:
> https://patchwork.kernel.org/patch/6995461/
Yes, your patch looks better than mine from the point of view
of covering intel_pstate_set_policy().
Still I have a question.
Does your patch allow the following condition?
limits.max_policy_pct > limits.min_perf_pct > limits.max_perf_pct > limits.min_policy_pct
Regards,
Ikarashi
next prev parent reply other threads:[~2015-09-07 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 10:58 [PATCH] intel_pstate: prevent max_perf_pct < min_perf_pct Seiichi Ikarashi
2015-09-07 9:00 ` Chen, Yu C
2015-09-07 21:46 ` Rafael J. Wysocki
2015-09-07 23:18 ` Seiichi Ikarashi [this message]
2015-09-08 7:27 ` Chen, Yu C
2015-09-09 4:27 ` Seiichi Ikarashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EE1B56.3010205@jp.fujitsu.com \
--to=s.ikarashi@jp.fujitsu.com \
--cc=kristen@linux.intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.