From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] omap3: cm-t3517: change environment size
Date: Tue, 8 Sep 2015 11:48:58 +0300 [thread overview]
Message-ID: <55EEA0FA.2060502@compulab.co.il> (raw)
In-Reply-To: <1441695002-15035-4-git-send-email-lifshitz@compulab.co.il>
Hi Dima,
On 09/08/15 09:50, Dmitry Lifshitz wrote:
> Mainline CM-T3517 U-Boot environment size differs from the that one
> shipped with CM-T3517 boards.
There is some strangeness in the above sentence...
>
> Update environment size, to avoid backward compatability issues.
s/compatability/compatibility/
>
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
> ---
> include/configs/cm_t3517.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h
> index 2d16799..36488d7 100644
> --- a/include/configs/cm_t3517.h
> +++ b/include/configs/cm_t3517.h
> @@ -66,8 +66,8 @@
> /*
> * Size of malloc() pool
> */
> -#define CONFIG_ENV_SIZE (16 << 10) /* 16 KiB */
> -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10))
> +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */
> +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (512 << 10))
Why do you change CONFIG_SYS_MALLOC_LEN?
Isn't it not enough?
If so, I would expect to see some explanation in the commit message.
--
Regards,
Igor.
next prev parent reply other threads:[~2015-09-08 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 6:49 [U-Boot] [PATCH 0/3] omap3: cm-t3517: series of non critical fixes Dmitry Lifshitz
2015-09-08 6:50 ` [U-Boot] [PATCH 1/3] omap3: cm-t3517: enable 'netretry' and setup timeout Dmitry Lifshitz
2015-09-08 8:39 ` Igor Grinberg
2015-09-12 12:52 ` [U-Boot] [U-Boot, " Tom Rini
2015-09-08 6:50 ` [U-Boot] [PATCH 2/3] omap3: cm-t3517: fix MMC1 pinmux Dmitry Lifshitz
2015-09-08 8:40 ` Igor Grinberg
2015-09-12 12:52 ` [U-Boot] [U-Boot,2/3] " Tom Rini
2015-09-08 6:50 ` [U-Boot] [PATCH 3/3] omap3: cm-t3517: change environment size Dmitry Lifshitz
2015-09-08 8:48 ` Igor Grinberg [this message]
2015-09-09 8:25 ` [U-Boot] [PATCH v2 " Dmitry Lifshitz
2015-09-09 8:37 ` Igor Grinberg
2015-09-12 12:52 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EEA0FA.2060502@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.