From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754118AbbIHIta (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 04:49:30 -0400
Received: from hotel311.server4you.de ([85.25.146.15]:51446 "EHLO
	hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753044AbbIHIt1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 04:49:27 -0400
Subject: Re: [RFC v0 4/9] smpboot: Use freeze_active() instead CPU_DEAD_FROZEN
 state information
To: Daniel Wagner <daniel.wagner@bmw-carit.de>, linux-kernel@vger.kernel.org
References: <1441373702-31796-1-git-send-email-daniel.wagner@bmw-carit.de>
 <1441373702-31796-5-git-send-email-daniel.wagner@bmw-carit.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Chris Metcalf <cmetcalf@ezchip.com>, Don Zickus <dzickus@redhat.com>,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Lai Jiangshan <laijs@cn.fujitsu.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
From: Daniel Wagner <wagi@monom.org>
Message-ID: <55EEA114.1010404@monom.org>
Date: Tue, 8 Sep 2015 10:49:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1441373702-31796-5-git-send-email-daniel.wagner@bmw-carit.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/04/2015 03:34 PM, Daniel Wagner wrote:
> In order to get rid of all CPU_*_FROZEN states we need to convert all
> users first.
> 
> cpu_check_up_prepare() wants to report different errors depending on
> an ongoing suspend or not. freeze_active() reports back if that is the
> case so we don't have to rely on the CPU_DEAD_FROZEN anymore.

Just realized, this is patch doesn't make sense. The FROZEN bits in the
current code have nothing to do with CPU_TASK_FROZEN. Instead it should
use CPU_DEAD_TIMEOUT as explained in patch 01.