From: Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, broonie@kernel.org,
khilman@linaro.org, tyler.baker@linaro.org,
shuahkh@osg.samsung.com
Subject: Re: [PATCH v2 5/6] selftests: change install command to rsync
Date: Tue, 8 Sep 2015 17:25:40 +0800 [thread overview]
Message-ID: <55EEA994.8060207@linaro.org> (raw)
In-Reply-To: <1441691528.14597.15.camel@ellerman.id.au>
Hi, Michael
On 09/08/2015 01:52 PM, Michael Ellerman wrote:
> On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:
>> The command of install could not handle the special files in exec
>> testcases, change the default rule to rsync to fix this.
>> The result of installation is unchanged after this commit.
>>
>> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
>
> Ah OK, I did suggest it. You never replied to my mail suggesting it though.
>
> I assume you tested it and it worked for all cases?
yes, I compare the installed file.
>
>> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
>> index 0acbeca..4e6ed13 100644
>> --- a/tools/testing/selftests/ftrace/Makefile
>> +++ b/tools/testing/selftests/ftrace/Makefile
>> @@ -1,7 +1,7 @@
>> all:
>>
>> TEST_PROGS := ftracetest
>> -TEST_DIRS := test.d/
>> +TEST_DIRS := test.d
>>
>> include ../lib.mk
>>
>> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
>> index 97f1c67..50a93f5 100644
>> --- a/tools/testing/selftests/lib.mk
>> +++ b/tools/testing/selftests/lib.mk
>> @@ -12,13 +12,10 @@ run_tests: all
>> $(RUN_TESTS)
>>
>> define INSTALL_RULE
>> - @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \
>> - mkdir -p $(INSTALL_PATH); \
>> - for TEST_DIR in $(TEST_DIRS); do \
>> - cp -r $$TEST_DIR $(INSTALL_PATH); \
>> - done; \
>> - echo "install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)"; \
>> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); \
>> + @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \
>> + mkdir -p ${INSTALL_PATH}; \
>> + echo "rsync -a $(TEST_DIRS) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(INSTALL_PATH)/"; \
>
> What is the echo for?
For output the following rsync command during building.
Do you mean there is some better way to do it?
regards
bamvor
>
>> + rsync -a $(TEST_DIRS) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(INSTALL_PATH)/; \
>> fi
>> endef
>>
>
> cheers
>
>
next prev parent reply other threads:[~2015-09-08 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 14:04 [PATCH v2 0/6] kselftest improvement and cleanup Bamvor Jian Zhang
2015-09-07 14:04 ` [PATCH v2 1/6] selftests: rename jump label to static_keys Bamvor Jian Zhang
2015-09-08 5:39 ` Michael Ellerman
2015-09-07 14:04 ` [PATCH v2 2/6] selftests: only compile userfaultfd for x86 and powperpc Bamvor Jian Zhang
2015-09-08 5:41 ` Michael Ellerman
2015-09-07 14:04 ` [PATCH v2 3/6] selftests: mqueue: allow extra cflags Bamvor Jian Zhang
2015-09-08 5:44 ` Michael Ellerman
2015-09-07 14:04 ` [PATCH v2 4/6] selftests: mqueue: simpification the Makefile Bamvor Jian Zhang
2015-09-08 5:47 ` Michael Ellerman
2015-09-07 14:04 ` [PATCH v2 5/6] selftests: change install command to rsync Bamvor Jian Zhang
2015-09-08 5:52 ` Michael Ellerman
2015-09-08 9:25 ` Bamvor Zhang Jian [this message]
2015-09-08 9:39 ` Michael Ellerman
2015-09-08 9:40 ` Bamvor Zhang Jian
2015-09-07 14:04 ` [PATCH v2 6/6] selftests: exec: simpification the Makefile Bamvor Jian Zhang
2015-09-08 5:57 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EEA994.8060207@linaro.org \
--to=bamvor.zhangjian@linaro.org \
--cc=broonie@kernel.org \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=shuahkh@osg.samsung.com \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.