From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2] mbuf/ip_frag: Move mbuf chaining to common code
Date: Tue, 08 Sep 2015 12:40:51 +0200 [thread overview]
Message-ID: <55EEBB33.6050300@netinsight.net> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A841A7@irsmsx105.ger.corp.intel.com>
On 2015-09-08 01:21, Ananyev, Konstantin wrote:
>>
>> Thanks. I got it wrong anyway, what I wanted was to be able to handle
>> the day when nb_segs changes to a 16-bit number, but then it should
>> really be
>>
>> ... >= 1 << (sizeof(head->nb_segs) * 8)
>>
>> anyway. I'll fix that and also add a warning that the implementation
>> will do a linear search to find the tail entry.
>
> Probably just me, but I can't foresee the situation when we would need to increase nb_segs to 16 bits.
> Looks like an overkill to me.
I don't think it will happen either, but with this solution, this
particular piece of code will work regardless. The value is known at
compile-time anyway, so it should not be a performance issue.
// Simon
next prev parent reply other threads:[~2015-09-08 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 12:41 [PATCH RFC] mbuf/ip_frag: Move mbuf chaining to common code Simon Kagstrom
2015-09-07 7:32 ` Olivier MATZ
2015-09-07 9:13 ` Ananyev, Konstantin
2015-09-07 9:35 ` Olivier MATZ
2015-09-07 10:40 ` Simon Kågström
2015-09-07 11:43 ` [PATCH v2] " Simon Kagstrom
2015-09-07 12:32 ` Ananyev, Konstantin
2015-09-07 12:41 ` Simon Kågström
2015-09-07 23:21 ` Ananyev, Konstantin
2015-09-08 10:40 ` Simon Kågström [this message]
2015-09-09 8:22 ` Ananyev, Konstantin
2015-09-07 12:50 ` [PATCH v3] " Simon Kagstrom
2015-10-13 12:50 ` Simon Kagstrom
2015-10-13 13:17 ` Thomas Monjalon
2015-10-13 13:11 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EEBB33.6050300@netinsight.net \
--to=simon.kagstrom@netinsight.net \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.