From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] efi: introduce efi_arch_flush_dcache_area Date: Tue, 8 Sep 2015 12:21:01 +0100 Message-ID: <55EEC49D.5070102@citrix.com> References: <1441708697-578-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZZGzE-0003X6-0d for xen-devel@lists.xenproject.org; Tue, 08 Sep 2015 11:22:52 +0000 In-Reply-To: <1441708697-578-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Mark Rutland , wei.liu2@citrix.com, ian.campbell@citrix.com, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 08/09/15 11:38, Stefano Stabellini wrote: > Objects loaded by FileHandle->Read need to be flushed from dcache, > otherwise copy_from_paddr will read stale data when copying the kernel, > causing a failure to boot. It would have been nice to have some explanation why we can read stale data in the commit message (see [1]). It would avoid to look at the ML in the future to understand why this patch is here. > Introduce efi_arch_flush_dcache_area and call it from read_file. > > This commit introduces no functional changes on x86. [1] http://www.gossamer-threads.com/lists/xen/devel/396892#396892 Regards, -- Julien Grall