From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZHAe-0005fG-5n for qemu-devel@nongnu.org; Tue, 08 Sep 2015 07:34:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZHAa-0007QE-6D for qemu-devel@nongnu.org; Tue, 08 Sep 2015 07:34:40 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:57617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZHAa-0007Q5-0X for qemu-devel@nongnu.org; Tue, 08 Sep 2015 07:34:36 -0400 References: <1441708451-12699-1-git-send-email-alex.smith@imgtec.com> From: Leon Alrae Message-ID: <55EEC7C4.4030801@imgtec.com> Date: Tue, 8 Sep 2015 12:34:28 +0100 MIME-Version: 1.0 In-Reply-To: <1441708451-12699-1-git-send-email-alex.smith@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Smith , qemu-devel@nongnu.org Cc: Alex Smith , Aurelien Jarno On 08/09/15 11:34, Alex Smith wrote: > For RDHWR on the CP0.Count register, env->CP0_Count was being returned. > This value is a delta against the QEMU_CLOCK_VIRTUAL clock, not the > correct current value of CP0.Count. Use cpu_mips_get_count() instead. > > Signed-off-by: Alex Smith > Cc: Aurelien Jarno > Cc: Leon Alrae > --- > Changes in v2: > - Fix build breakage for user builds. > - Correct existing code to follow QEMU coding style. > --- > target-mips/op_helper.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Leon Alrae