From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZZJAa-0005M3-WC
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 09:42:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZZJAX-0007KI-5U
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 09:42:44 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:31185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZZJAX-0007Jo-0D
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 09:42:41 -0400
References: <1440703987-29012-1-git-send-email-lvivier@redhat.com>
	<1440703987-29012-5-git-send-email-lvivier@redhat.com>
From: Leon Alrae <leon.alrae@imgtec.com>
Message-ID: <55EEE5C8.6030507@imgtec.com>
Date: Tue, 8 Sep 2015 14:42:32 +0100
MIME-Version: 1.0
In-Reply-To: <1440703987-29012-5-git-send-email-lvivier@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 4/9] mips: remove muldiv64()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org, Aurelien
	Jarno <aurelien@aurel32.net>

On 27/08/15 20:33, Laurent Vivier wrote:
> Originally, timers were ticks based, and it made sense to
> add ticks to current time to know when to trigger an alarm.
> 
> But since commit:
> 
> 7447545 change all other clock references to use nanosecond resolution accessors
> 
> All timers use nanoseconds and we need to convert ticks to nanoseconds, by
> doing something like:
> 
>     y = muldiv64(x, get_ticks_per_sec(), TIMER_FREQ)
> 
> where x is the number of device ticks and y the number of system ticks.
> 
> y is used as nanoseconds in timer functions,
> it works because 1 tick is 1 nanosecond.
> (get_ticks_per_sec() is 10^9)
> 
> But as MIPS timer frequency is 100 MHz, we can also do:
> 
>     y = x * 10; /* 100 MHz period is 10 ns */
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  hw/mips/cputimer.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>