From: Tim Gardner <tim.gardner@canonical.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n
Date: Tue, 8 Sep 2015 17:19:51 -0600 [thread overview]
Message-ID: <55EF6D17.6050809@canonical.com> (raw)
In-Reply-To: <20150908224735.GA12791@fergus.ozlabs.ibm.com>
On 09/08/2015 04:47 PM, Paul Mackerras wrote:
> On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gardner@canonical.com wrote:
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx()
>> routine available") neglected to define an empty inline replacement for
>> enable_kernel_vsx() when CONFIG_VSX=n.
>
> If code that wants to call enable_kernel_vsx() is getting compiled in
> when CONFIG_VSX=n, that's a worry. Is this patch motivated by an
> actual compile failure? If so what was the failure?
>
> Paul.
>
I was having link failures after backporting 'crypto: nx' patches to a
4.2 based kernel. You may have a point in that the upstream Kconfig will
not allow those files to be compiled if CONFIG_VSX=n. I will check in my
morning if to see if I can reproduce the same link error in mainline.
rtg
--
Tim Gardner tim.gardner@canonical.com
next prev parent reply other threads:[~2015-09-08 23:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 18:13 [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n tim.gardner
2015-09-08 22:47 ` Paul Mackerras
2015-09-08 23:19 ` Tim Gardner [this message]
2015-09-09 2:13 ` Michael Ellerman
2015-09-09 13:31 ` Tim Gardner
2015-09-10 0:52 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EF6D17.6050809@canonical.com \
--to=tim.gardner@canonical.com \
--cc=benh@kernel.crashing.org \
--cc=herbert@gondor.apana.org.au \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.