All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Salyzyn <salyzyn-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
To: Hiraku Toyooka
	<hiraku.toyooka.gu-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Seiji Aguchi <seiji.aguchi-7rDLJAbr9SE@public.gmane.org>
Subject: Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Date: Tue, 08 Sep 2015 16:22:45 -0700	[thread overview]
Message-ID: <55EF6DC5.2080207@android.com> (raw)
In-Reply-To: <20150908110617.9783.4635.stgit@arietta>

On 09/08/2015 04:06 AM, Hiraku Toyooka wrote:
> The pstore_tests script includes test cases which check pstore's
> behavior before crash (and reboot).
>
> The test cases are currently following.
>
> - Check pstore backend is registered
> - Check pstore console is registered
> - Check /dev/pmsg0 exists
> - Write string to /dev/pmsg0
>
> . . .
> +TEST_STRING="Testing pstore"
. . .
> +prlog -n "Checking pmsg file contains TEST_STRING ... "
> +grep -q "${TEST_STRING}" pmsg-${backend}-0
Mark this as 'wish to have'

Can TEST_STRING be given an unique value each run, so that on the the 
reboot-comparison run it can be found to be an unique match? Also 
confirm that any previous content (which may be binary) is not present 
after reboot, and that totally new content is present.

Sincerely -- Mark Salyzyn

WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>,
	linux-kernel@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>,
	Kees Cook <keescook@chromium.org>,
	linux-api@vger.kernel.org, Anton Vorontsov <anton@enomsg.org>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Colin Cross <ccross@android.com>,
	Seiji Aguchi <seiji.aguchi@hds.com>
Subject: Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Date: Tue, 08 Sep 2015 16:22:45 -0700	[thread overview]
Message-ID: <55EF6DC5.2080207@android.com> (raw)
In-Reply-To: <20150908110617.9783.4635.stgit@arietta>

On 09/08/2015 04:06 AM, Hiraku Toyooka wrote:
> The pstore_tests script includes test cases which check pstore's
> behavior before crash (and reboot).
>
> The test cases are currently following.
>
> - Check pstore backend is registered
> - Check pstore console is registered
> - Check /dev/pmsg0 exists
> - Write string to /dev/pmsg0
>
> . . .
> +TEST_STRING="Testing pstore"
. . .
> +prlog -n "Checking pmsg file contains TEST_STRING ... "
> +grep -q "${TEST_STRING}" pmsg-${backend}-0
Mark this as 'wish to have'

Can TEST_STRING be given an unique value each run, so that on the the 
reboot-comparison run it can be found to be an unique match? Also 
confirm that any previous content (which may be binary) is not present 
after reboot, and that totally new content is present.

Sincerely -- Mark Salyzyn



  reply	other threads:[~2015-09-08 23:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 11:06 [PATCH 0/2] selftests/pstore: add pstore test script Hiraku Toyooka
2015-09-08 11:06 ` [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka
2015-09-08 23:22   ` Mark Salyzyn [this message]
2015-09-08 23:22     ` Mark Salyzyn
     [not found]     ` <55EF6DC5.2080207-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2015-09-15  2:30       ` Hiraku Toyooka
2015-09-15  2:30         ` Hiraku Toyooka
2015-09-21 21:04         ` Mark Salyzyn
     [not found]           ` <560070D0.90709-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2015-09-29  7:18             ` Hiraku Toyooka
2015-09-29  7:18               ` Hiraku Toyooka
2015-09-08 23:37   ` Kees Cook
2015-09-08 23:37     ` Kees Cook
     [not found]     ` <CAGXu5jKLaoAjE5uYkbQW-o6TcjwDL-PS3=HndjD1LpTnN-rnAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-15  2:31       ` Hiraku Toyooka
2015-09-15  2:31         ` Hiraku Toyooka
     [not found]         ` <55F782E8.80508-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>
2015-09-16 12:02           ` 阿口誠司 / AGUCHI，SEIJI
2015-09-16 12:02             ` 阿口誠司 / AGUCHI，SEIJI
     [not found]             ` <753241EEF6DFAB4CAF20F32F515C4E358B33C3-RKwZE6o2dOX6mtb5pcma++hNMziWB107FCd8Q96Dh0LR7s880joybQ@public.gmane.org>
2015-09-17  5:54               ` Hiraku Toyooka
2015-09-17  5:54                 ` Hiraku Toyooka
2015-09-08 11:06 ` [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot Hiraku Toyooka
2015-09-08 11:06   ` Hiraku Toyooka
2015-09-08 23:40   ` Kees Cook
     [not found]     ` <CAGXu5j+Ha0t-acFc+morgUiDRCHGdx8QHySX29PYpnj4QFiJhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-15  2:41       ` Hiraku Toyooka
2015-09-15  2:41         ` Hiraku Toyooka
2015-09-16 12:11         ` 阿口誠司 / AGUCHI，SEIJI
2015-09-16 12:11           ` 阿口誠司 / AGUCHI，SEIJI
     [not found]           ` <753241EEF6DFAB4CAF20F32F515C4E358B347A-RKwZE6o2dOX6mtb5pcma++hNMziWB107FCd8Q96Dh0LR7s880joybQ@public.gmane.org>
2015-09-17  5:54             ` Hiraku Toyooka
2015-09-17  5:54               ` Hiraku Toyooka
2015-09-08 23:42 ` [PATCH 0/2] selftests/pstore: add pstore test script Kees Cook
2015-09-08 23:42   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EF6DC5.2080207@android.com \
    --to=salyzyn-z5hga2qsfarbdgjk7y7tuq@public.gmane.org \
    --cc=anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=hiraku.toyooka.gu-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=seiji.aguchi-7rDLJAbr9SE@public.gmane.org \
    --cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.