All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] mx6ul_14x14_evk: Remove CONFIG_SPL_FAT_SUPPORT
Date: Wed, 9 Sep 2015 09:37:17 +0200	[thread overview]
Message-ID: <55EFE1AD.2080902@denx.de> (raw)
In-Reply-To: <20150909032915.GB7343@shlinux2>

Hi Peng, Fabio,

On 09/09/2015 05:29, Peng Fan wrote:
> Hi Fabio,
> 
> On Tue, Sep 08, 2015 at 02:43:11PM -0300, Fabio Estevam wrote:
>> If the SD card does not contain the u-boot.img then we get the
>> following error:
>>
>> U-Boot SPL 2015.10-rc2-23947-g7ad5930 (Sep 08 2015 - 14:10:29)                  
>> ** Partition 1 not valid on device 0 **                                         
>> spl_register_fat_device: fat register err - -1                                  
>> spl_load_image_fat: error reading image u-boot.img, err - -1    
>>
>> Remove CONFIG_SPL_FAT_SUPPORT and let CONFIG_SPL_MMC_SUPPORT do the
>> job.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> include/configs/mx6ul_14x14_evk.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/configs/mx6ul_14x14_evk.h b/include/configs/mx6ul_14x14_evk.h
>> index 4a2280b..e785925 100644
>> --- a/include/configs/mx6ul_14x14_evk.h
>> +++ b/include/configs/mx6ul_14x14_evk.h
>> @@ -17,7 +17,6 @@
>> /* SPL options */
>> #define CONFIG_SPL_LIBCOMMON_SUPPORT
>> #define CONFIG_SPL_MMC_SUPPORT
>> -#define CONFIG_SPL_FAT_SUPPORT
> 
> Can we keep this? Without this, we need to burn u-boot.img into sdcard, but
> i prefer to load u-boot.img from the fat partition.

Well, how U-Boot is stored on the SD-Card is a decision that you take
based on the balance safety against comfortably.
Both are ok on my side. If we put u-boot.img in raw SD at a fixed
address, it is very uncommon that a user destroy accessing it. On the
other side, putting it into a FAT partition makes easier to update for
everybody - just copying it into a disk.
The issue reported by Fabio is like a corrupted SD-Card - the SD-Card
does not contain the correct bootloader and it is ok if it does not boot
or hangs. Both ways have advantages and disadvantages.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2015-09-09  7:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 17:43 [U-Boot] [PATCH 1/4] thermal: imx_thermal: Do not print on error Fabio Estevam
2015-09-08 17:43 ` [U-Boot] [PATCH 2/4] imx-common: cpu: Do not print on invalid temperature Fabio Estevam
2015-09-08 17:43 ` [U-Boot] [PATCH 3/4] mx6ul_14x14_evk: Remove CONFIG_SPL_FAT_SUPPORT Fabio Estevam
2015-09-09  3:29   ` Peng Fan
2015-09-09  7:37     ` Stefano Babic [this message]
2015-09-09 12:26       ` Fabio Estevam
2015-09-09 12:45         ` Otavio Salvador
2015-09-09 13:36         ` Stefano Babic
2015-09-09 13:33           ` Peng Fan
2015-09-09 15:47             ` Fabio Estevam
2015-09-13  8:54         ` Stefano Babic
2015-09-08 17:43 ` [U-Boot] [PATCH 4/4] mx6ul_14x14_evk: Add a README file Fabio Estevam
2015-09-13  8:50 ` [U-Boot] [PATCH 1/4] thermal: imx_thermal: Do not print on error Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EFE1AD.2080902@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.