All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, lina.iyer@linaro.org,
	nrajan@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.
Date: Wed, 09 Sep 2015 10:11:19 +0100	[thread overview]
Message-ID: <55EFF7B7.5050605@linaro.org> (raw)
In-Reply-To: <55EFA876.30708@codeaurora.org>



On 09/09/15 04:33, Rajendra Nayak wrote:
>
> On 09/09/2015 12:51 AM, Stephen Boyd wrote:
>> On 09/07, Rajendra Nayak wrote:
>>>>
>>>> Yeah this might happen though because we've assigned the of_node
>>>> pointer to the tsens device before we register it on the platform
>>>> bus. The other way to pass that data down from gcc to tsens would
>>>> be to not have an of_node assigned to the tsens device, and check
>>>> for that case in the tsens driver. If there isn't an of_node,
>>>> then we look at the parent device's of_node to figure out which
>>>> gcc it is (if this even matters) and parse DT properties.
>>>
>>> Parsing DT properties from parent (in the tsens driver) is fine, but
>>> the nvmem apis still expect an of_node for the tsens device and hence
>>> fail.
>>
>> So pass the parent device to the nvmem APIs? Or adjust the nvmem
>> APIs to look for a parent of_node if there isn't an of_node for
>> the device being passed? Or make the nvmem APIs work without
>> using DT, and copy over the nvmem information from the gcc node
>> to the virtual tsens child device?
>
> Srini, you being the nvmem maintainer, any thoughts?

We could do either one of the below.
1> pass parent device for nvmem_get_cell as suggested by Stephen
2> use of_nvmem_get_cell() api to pass correct of_node

Both of them would work.

--srini
>

WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.
Date: Wed, 09 Sep 2015 10:11:19 +0100	[thread overview]
Message-ID: <55EFF7B7.5050605@linaro.org> (raw)
In-Reply-To: <55EFA876.30708@codeaurora.org>



On 09/09/15 04:33, Rajendra Nayak wrote:
>
> On 09/09/2015 12:51 AM, Stephen Boyd wrote:
>> On 09/07, Rajendra Nayak wrote:
>>>>
>>>> Yeah this might happen though because we've assigned the of_node
>>>> pointer to the tsens device before we register it on the platform
>>>> bus. The other way to pass that data down from gcc to tsens would
>>>> be to not have an of_node assigned to the tsens device, and check
>>>> for that case in the tsens driver. If there isn't an of_node,
>>>> then we look at the parent device's of_node to figure out which
>>>> gcc it is (if this even matters) and parse DT properties.
>>>
>>> Parsing DT properties from parent (in the tsens driver) is fine, but
>>> the nvmem apis still expect an of_node for the tsens device and hence
>>> fail.
>>
>> So pass the parent device to the nvmem APIs? Or adjust the nvmem
>> APIs to look for a parent of_node if there isn't an of_node for
>> the device being passed? Or make the nvmem APIs work without
>> using DT, and copy over the nvmem information from the gcc node
>> to the virtual tsens child device?
>
> Srini, you being the nvmem maintainer, any thoughts?

We could do either one of the below.
1> pass parent device for nvmem_get_cell as suggested by Stephen
2> use of_nvmem_get_cell() api to pass correct of_node

Both of them would work.

--srini
>

  parent reply	other threads:[~2015-09-09  9:11 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08  9:47 [PATCH 0/9] qcom: Add support for TSENS driver Rajendra Nayak
2015-07-08  9:47 ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 1/9] thermal: qcom: tsens: Add a skeletal TSENS drivers Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 2/9] thermal: qcom: tsens-8916: Add support for 8916 family of SoCs Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 3/9] thermal: qcom: tsens-8974: Add support for 8974 " Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 4/9] thermal: qcom: tsens-8960: Add support for 8960 " Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-08-11 22:49   ` Stephen Boyd
2015-08-11 22:49     ` Stephen Boyd
2015-08-12  9:00     ` Srinivas Kandagatla
2015-08-12  9:00       ` Srinivas Kandagatla
2015-08-13  4:28       ` Rajendra Nayak
2015-08-13  4:28         ` Rajendra Nayak
2015-08-14  0:42         ` Stephen Boyd
2015-08-14  0:42           ` Stephen Boyd
2015-08-14  3:09           ` Rajendra Nayak
2015-08-14  3:09             ` Rajendra Nayak
2015-09-02  2:37             ` Rajendra Nayak
2015-09-02  2:37               ` Rajendra Nayak
2015-09-03 17:27               ` Stephen Boyd
2015-09-03 17:27                 ` Stephen Boyd
2015-09-07  6:39                 ` Rajendra Nayak
2015-09-07  6:39                   ` Rajendra Nayak
2015-09-08 19:21                   ` Stephen Boyd
2015-09-08 19:21                     ` Stephen Boyd
2015-09-09  3:33                     ` Rajendra Nayak
2015-09-09  3:33                       ` Rajendra Nayak
2015-09-09  5:15                       ` Rajendra Nayak
2015-09-09  5:15                         ` Rajendra Nayak
2015-09-09  9:11                       ` Srinivas Kandagatla [this message]
2015-09-09  9:11                         ` Srinivas Kandagatla
2015-08-12 20:18     ` Bjorn Andersson
2015-08-12 20:18       ` Bjorn Andersson
2015-08-12 21:57       ` Stephen Boyd
2015-08-12 21:57         ` Stephen Boyd
2015-08-13  4:14         ` Bjorn Andersson
2015-08-13  4:14           ` Bjorn Andersson
2015-08-14  0:46           ` Stephen Boyd
2015-08-14  0:46             ` Stephen Boyd
2015-07-08  9:47 ` [PATCH 6/9] arm: dts: msm8974: Add thermal zones, tsens and eeprom nodes Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 7/9] arm: dts: apq8064: " Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 8/9] arm: dts: apq8084: " Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-07-08  9:47 ` [PATCH 9/9] arm64: dts: msm8916: " Rajendra Nayak
2015-07-08  9:47   ` Rajendra Nayak
2015-08-11  8:26 ` [PATCH 0/9] qcom: Add support for TSENS driver Srinivas Kandagatla
2015-08-11  8:26   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EFF7B7.5050605@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nrajan@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.