From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Date: Wed, 09 Sep 2015 09:16:57 +0000 Subject: Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent Message-Id: <55EFF909.7090500@ti.com> List-Id: References: <1441731636-17610-1-git-send-email-geert+renesas@glider.be> <1441731636-17610-2-git-send-email-geert+renesas@glider.be> <55EFF11A.1050400@ti.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner Cc: Geert Uytterhoeven , Marc Zyngier , Geert Uytterhoeven , Jason Cooper , Sudeep Holla , Magnus Damm , Linux-sh list , "linux-kernel@vger.kernel.org" On 09/09/2015 11:53 AM, Thomas Gleixner wrote: > On Wed, 9 Sep 2015, Grygorii Strashko wrote: >> On 09/08/2015 11:03 PM, Thomas Gleixner wrote: >>> So, yes a seperate locking class for that intc trainwreck is probably >>> required. >>> >> >> Just as an option, May be we can proceed with patch: >> [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE >> http://www.spinics.net/lists/linux-omap/msg121262.html >> >> As result, irq_chip_set_wake_parent() can be used here and no lockdep issues. > > The driver in question is not using hierarchical irq domains. So what > would that patch solve? > You are right. I misunderstood it. Sorry for the noise. -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbbIIJRi (ORCPT ); Wed, 9 Sep 2015 05:17:38 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:44140 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbbIIJRa (ORCPT ); Wed, 9 Sep 2015 05:17:30 -0400 Subject: Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent To: Thomas Gleixner References: <1441731636-17610-1-git-send-email-geert+renesas@glider.be> <1441731636-17610-2-git-send-email-geert+renesas@glider.be> <55EFF11A.1050400@ti.com> CC: Geert Uytterhoeven , Marc Zyngier , Geert Uytterhoeven , Jason Cooper , Sudeep Holla , Magnus Damm , Linux-sh list , "linux-kernel@vger.kernel.org" From: Grygorii Strashko Message-ID: <55EFF909.7090500@ti.com> Date: Wed, 9 Sep 2015 12:16:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2015 11:53 AM, Thomas Gleixner wrote: > On Wed, 9 Sep 2015, Grygorii Strashko wrote: >> On 09/08/2015 11:03 PM, Thomas Gleixner wrote: >>> So, yes a seperate locking class for that intc trainwreck is probably >>> required. >>> >> >> Just as an option, May be we can proceed with patch: >> [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE >> http://www.spinics.net/lists/linux-omap/msg121262.html >> >> As result, irq_chip_set_wake_parent() can be used here and no lockdep issues. > > The driver in question is not using hierarchical irq domains. So what > would that patch solve? > You are right. I misunderstood it. Sorry for the noise. -- regards, -grygorii