From mboxrd@z Thu Jan  1 00:00:00 1970
From: elfring@users.sourceforge.net (SF Markus Elfring)
Date: Wed, 9 Sep 2015 14:14:15 +0200
Subject: [Cocci] Comments removed on (adjacent) lines not touched ... ?
In-Reply-To: <CAB3z_Rpt-nF3=V_OFcBiLkYvbPefPZXA0DsRm+BUJU6gG95RMw@mail.gmail.com>
References: <CAB3z_Rpt-nF3=V_OFcBiLkYvbPefPZXA0DsRm+BUJU6gG95RMw@mail.gmail.com>
Message-ID: <55F02297.6070503@users.sourceforge.net>
To: cocci@systeme.lip6.fr
List-Id: cocci@systeme.lip6.fr

> Reviewing the changes made by my s-patch, I've come across the following hunk :

How do you think about to show your semantic patch script here?


> +++ b/drivers/hwmon/jc42.c
> ...
> @@ -529,13 +529,7 @@ static const struct dev_pm_ops jc42_dev_pm_ops = {
>  #define JC42_DEV_PM_OPS (&jc42_dev_pm_ops)
>  #else
>  #define JC42_DEV_PM_OPS NULL
> -#endif /* CONFIG_PM */
> -
> -static const struct i2c_device_id jc42_id[] = {
> -       { "jc42", 0 },
> -       { }
> -};
> -MODULE_DEVICE_TABLE(i2c, jc42_id);
> +#endif
>
>  static struct i2c_driver jc42_driver = {
>         .class          = I2C_CLASS_SPD,
> ============================================================
>
> Is this removal of the /* CONFIG_PM */ expected behaviour?

I would interpret the shown changes in the way that a preprocessor
statement "#endif" is repositioned after a variable initialisation which
was not a part for conditional compilation is deleted. I find such a
detail also strange.


> I guess under the hood, Coccinelle is stripping comments from code to
> make parsing possible/easier?

This software is tackling some challenges to preserve comments for
various source code places.

Regards,
Markus