From: David Vrabel <david.vrabel@citrix.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <live-patching@vger.kernel.org>,
"Michal Marek" <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
"Pedro Alves" <palves@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
"Bernd Petrovitsch" <bernd@petrovitsch.priv.at>,
Chris J Arges <chris.j.arges@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v12 07/21] x86/xen: Add stack frame dependency to hypercall inline asm calls
Date: Wed, 9 Sep 2015 14:30:27 +0100 [thread overview]
Message-ID: <55F03473.50708@citrix.com> (raw)
In-Reply-To: <ec811627e3a3e3ff138cf7e47e89ce43cbaf30ef.1441749989.git.jpoimboe@redhat.com>
On 09/09/15 14:21, Josh Poimboeuf wrote:
> If a hypercall is inlined at the beginning of a function, gcc can insert
> the call instruction before setting up a stack frame, which breaks frame
> pointer convention if CONFIG_FRAME_POINTER is enabled and can result in
> a bad stack trace.
>
> Force a stack frame to be created if CONFIG_FRAME_POINTER is enabled by
> listing the stack pointer as an output operand for the hypercall inline
> asm statements.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2015-09-09 13:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 13:21 [PATCH v12 00/21] Compile-time stack metadata validation Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 01/21] tools: Fix formatting of the "make -C tools" help message Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 02/21] x86/asm: Frame pointer macro cleanup Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 03/21] x86/asm: Add C versions of frame pointer macros Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 04/21] x86/stacktool: Compile-time stack metadata validation Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 05/21] x86/stacktool: Add file and directory ignores Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 06/21] x86/stacktool: Add ignore macros Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 07/21] x86/xen: Add stack frame dependency to hypercall inline asm calls Josh Poimboeuf
2015-09-09 13:30 ` David Vrabel [this message]
2015-09-09 13:21 ` [PATCH v12 08/21] x86/paravirt: Add stack frame dependency to PVOP " Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 09/21] x86/paravirt: Create a stack frame in PV_CALLEE_SAVE_REGS_THUNK Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 10/21] x86/amd: Set ELF function type for vide() Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 11/21] x86/reboot: Add ljmp instructions to stacktool whitelist Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 12/21] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stacktool whitelists Josh Poimboeuf
2015-09-09 13:31 ` David Vrabel
2015-09-09 13:21 ` [PATCH v12 13/21] x86/asm/crypto: Create stack frames in aesni-intel_asm.S Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 14/21] x86/asm/crypto: Move .Lbswap_mask data to .rodata section Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 15/21] x86/asm/crypto: Move jump_table " Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 16/21] x86/asm/crypto: Create stack frames in clmul_ghash_mul/update() Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 17/21] x86/asm/entry: Create stack frames in thunk functions Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 18/21] x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 19/21] x86/asm: Create stack frames in rwsem functions Josh Poimboeuf
2015-09-09 13:21 ` [PATCH v12 20/21] x86/asm/efi: Create a stack frame in efi_call() Josh Poimboeuf
2015-09-09 13:22 ` [PATCH v12 21/21] x86/asm/power: Create stack frames in hibernate_asm_64.S Josh Poimboeuf
2015-09-15 16:57 ` [PATCH v12 00/21] Compile-time stack metadata validation Chris J Arges
2015-09-15 18:11 ` Josh Poimboeuf
2015-09-17 22:14 ` [PATCH 0/3] A few stacktool warning fixes Chris J Arges
2015-09-17 22:14 ` [PATCH 1/3] x86/uaccess: Add stack frame output operand in get_user inline asm Chris J Arges
2015-09-18 13:57 ` Josh Poimboeuf
2015-09-17 22:14 ` [PATCH 2/3] x86/stacktool: Ignore head_$(BITS) files Chris J Arges
2015-09-18 13:57 ` Josh Poimboeuf
2015-09-17 22:14 ` [PATCH 3/3] kprobes/x86: stacktool: ignore kretprobe_trampoline_holder Chris J Arges
2015-09-18 14:04 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F03473.50708@citrix.com \
--to=david.vrabel@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bernd@petrovitsch.priv.at \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=chris.j.arges@canonical.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@gmail.com \
--cc=palves@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.