From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Stephan Mueller <smueller@chronox.de>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
qat-linux@intel.com
Subject: Re: [PATCH 4/8] crypto: akcipher - Changes to asymmetric key API
Date: Wed, 9 Sep 2015 09:29:28 -0700 [thread overview]
Message-ID: <55F05E68.1010205@intel.com> (raw)
In-Reply-To: <3897798.9eVMxC27Hh@tauon.atsec.com>
Hi Stephan,
On 09/09/2015 09:25 AM, Stephan Mueller wrote:
>> >+#if 0
>> > static int do_test_rsa(struct crypto_akcipher *tfm,
>> > struct akcipher_testvec *vecs)
>> > {
>> >@@ -1975,6 +1976,7 @@ static int alg_test_akcipher(const struct alg_test_desc
>> >*desc, crypto_free_akcipher(tfm);
>> > return err;
>> > }
>> >+#endif
> Just to check: is the ifdef 0 intentional?
Yes, it is otherwise it will break the build. It is enabled in subsequent patch.
>> + * @key: BER encoded public key
> DER encoded?
>
It is BER (Basic Encoding Rules), which is also valid DER (Distinguished Encoding Rules)
Regards
T
next prev parent reply other threads:[~2015-09-09 16:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 16:14 [PATCH 0/8] crypto: Updates to akcipher API Tadeusz Struk
2015-09-09 16:15 ` [PATCH 1/8] crypto: akcipher - return status from crypto_unregister_alg Tadeusz Struk
2015-09-18 11:29 ` Herbert Xu
2015-09-09 16:15 ` [PATCH 2/8] crypto: rsa - check status returned from crypto_unregister_akcipher Tadeusz Struk
2015-09-09 16:15 ` [PATCH 3/8] crypto: qat " Tadeusz Struk
2015-09-09 16:15 ` [PATCH 4/8] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-09-09 16:25 ` Stephan Mueller
2015-09-09 16:29 ` Tadeusz Struk [this message]
2015-09-09 16:41 ` Stephan Mueller
2015-09-09 16:44 ` Tadeusz Struk
2015-09-09 18:53 ` Andrzej Zaborowski
2015-09-09 19:13 ` Stephan Mueller
2015-09-09 19:35 ` Tadeusz Struk
2015-09-18 11:35 ` Herbert Xu
2015-09-09 16:15 ` [PATCH 5/8] lib/scatterlist: Add sg_len helper Tadeusz Struk
2015-09-09 16:27 ` Stephan Mueller
2015-09-09 16:31 ` Tadeusz Struk
2015-09-09 16:39 ` Stephan Mueller
2015-09-09 16:46 ` Tadeusz Struk
2015-09-09 16:49 ` Stephan Mueller
2015-09-09 16:51 ` Tadeusz Struk
2015-09-09 16:56 ` Stephan Mueller
2015-09-09 17:02 ` Tadeusz Struk
2015-09-09 17:05 ` Stephan Mueller
2015-09-09 17:16 ` Tadeusz Struk
2015-09-09 17:37 ` Stephan Mueller
2015-09-09 16:54 ` Stephan Mueller
2015-09-09 16:15 ` [PATCH 6/8] crypto: rsa - update accoring to akcipher API changes Tadeusz Struk
2015-09-09 16:35 ` Stephan Mueller
2015-09-09 18:03 ` Tadeusz Struk
2015-09-09 16:15 ` [PATCH 7/8] crypto: qat " Tadeusz Struk
2015-09-09 16:15 ` [PATCH 8/8] crypto: testmgr - update test mgr according to " Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F05E68.1010205@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.