From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH v2] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages. Date: Wed, 9 Sep 2015 10:53:04 -0700 Message-ID: <55F07200.9060209@caviumnetworks.com> References: <1441736911-2445-1-git-send-email-ddaney.cavm@gmail.com> <55F06FE3.9020600@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55F06FE3.9020600@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: frowand.list@gmail.com Cc: David Daney , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Grant Likely , David Daney List-Id: devicetree@vger.kernel.org On 09/09/2015 10:44 AM, Frank Rowand wrote: > Second attempt at this reply. The first reply was mangled. > > On 9/8/2015 11:28 AM, David Daney wrote: >> From: David Daney >> >> It is perfectly legitimate for a PCI device to have an >> PCI_INTERRUPT_PIN value of zero. This happens if the device doesn't >> use interrupts, or on PCIe devices, where only MSI/MSI-X are >> supported. >> >> Silence the annoying "of_irq_parse_pci() failed with rc=-19" error >> messages by moving the printing code into of_irq_parse_pci(), and only >> emitting the message for cases where PCI_INTERRUPT_PIN == 0 is not the >> cause for an early exit. >> >> Signed-off-by: David Daney >> --- >> Changes in v2: Move the print function in to of_irq_parse_pci() at a >> common error exit point (as suggested by Frank Rowand). >> >> [...] >> @@ -87,6 +89,9 @@ int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq >> laddr[0] = cpu_to_be32((pdev->bus->number << 16) | (pdev->devfn << 8)); >> laddr[1] = laddr[2] = cpu_to_be32(0); > >> return of_irq_parse_raw(laddr, out_irq); > > should be: > > rc = of_irq_parse_raw(laddr, out_irq); > if (rc) > goto err; > return 0; > You are right. I will send v3. Thanks, David Daney >> +err: >> + dev_err(&pdev->dev, "of_irq_parse_pci() failed with rc=%d\n", rc); >> + return rc; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbbIIRxQ (ORCPT ); Wed, 9 Sep 2015 13:53:16 -0400 Received: from mail-by2on0061.outbound.protection.outlook.com ([207.46.100.61]:35200 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750819AbbIIRxN (ORCPT ); Wed, 9 Sep 2015 13:53:13 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <55F07200.9060209@caviumnetworks.com> Date: Wed, 9 Sep 2015 10:53:04 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: CC: David Daney , , , Rob Herring , Grant Likely , David Daney Subject: Re: [PATCH v2] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages. References: <1441736911-2445-1-git-send-email-ddaney.cavm@gmail.com> <55F06FE3.9020600@gmail.com> In-Reply-To: <55F06FE3.9020600@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BN1PR07CA0036.namprd07.prod.outlook.com (10.255.193.11) To BY1PR0701MB1723.namprd07.prod.outlook.com (25.162.111.142) X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1723;2:CJOFtGIS8C5f4OGeQO6EXtjq1nqL0qZ7zIgHNX5Eje59hq85rXJ5QB+bDkj0ZtphK6j2jeQIgf+HiX1HE8sxX9L35NCllfLL3HKmbm6QYeC3Cq9xxkG755DPmgbdWFP0Hxg1lbgHu/OXLCPVTUhB1ciaqyU4lSRpJmeZTyawk8A=;3:SRXwx8RiMzMIYKQqCNiOJ/4gpXaxKlZC30ClAHW4CDBeErfdDA8r4zuUNMJ05HT0CDkBpfKSwhFlH+PrvTZqsc/51smFGKUsHzkMaBmqWhyRwYrxa3krYKdSywirK9N3zZVN96yr8PYJjmcSd+SxBg==;25:UxVJfuLDlXIyVX+C/f1lURIaNFZUgFmAwpb/j00HxSJKhbUYxoevraPLBEUp1nPBvoh0cuQuU0AHzpFkXUAoRC0dh2bEIzY/m1wYz/1bvEN+n6tPEVvKHj6hJM8lhJJ3cYc9Hulig7XmMM9c7AS0BybFXDgsfzSiJP+gOklOSWE8BrLZSYTuEtio3EVUHahRE2sGBSCblQ5TOJDGPE45f4gTmU9xWLCAsPOJcNllpXIH+i/kcTYgLUTdeWz0Y+WAtaZ0H4+xa5AkdzWuqxDxow== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1723; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1723;20:0NSlNQw+N41YSoLD7Pg2IPCZIuqvAHYPxUXrtwmS9KdyZRcQjT5MNV+aEIQi9ZaeOFI1qzfqBU9A3zITGVzWq6H231Au4NMgeWL33ViwfChj3GRokfRrXIefHZVc0rkia4wpFIpXeI78JvDYqucnR5xaC/zHhEsG6mc8j7JjWaUPo8tc3IaA2uhlqlz3mXvnrxkDxaetZKKnTTysEnrVTqGRFKn6vgB47QZtgBk1t2Hjnfw3d6lVMpxwYPgtf2eILhrlQGroX4IrtcwBwly1hC/tgb9n8HWfqRPCeIyFtT+fhlHYLzoiby9m9LSc+vSxX3f8hpSWNVt0PoQOtk5tac6ZJ9lb1LL1NGWqxb0ZYvKd6RfAZOSBeeEpqnsAFweD/O9xb3IPCZFpQW9dSNSRiI6rRRCF7ax6oKAlGRk4Tl6yOmzaTFtDpL86QHGNyWQS36pQMIF0cn+Rf0RGjoXEf9+d5p/4HKBw5ddqGGLoXhJYls+pMwYZcnZoDymMeusylUG5R2jaLB2N7Zi/k9nLrCmOdj3VNyu2peKzXg6q1fzoUd7s27ngV0wRU+zoHU9LW8RShvESEvwkhlCMvTkgX+J89oms51r1GMZNeVdeH7c=;4:byXcITxTPXZV72apP6ongmR/scXn5kD/Eos+bR10+xboWyHb7/KiL40MdmLXgl7f95JucySVOkxfMfxf8v9Eo8li7YnOBZouTnV9/rbbEzmEwRfKc3mY/XhPshDLGR7Xx4SL55gBDWRCZGzSK8NVZm6hJJ7mwxAz2Lg1xSiM+w/Vz7RnCh45g+Isy4OVKOaB0TWw7w1M01HWHWVQh55TmkN1FKK2h8L2Pylj1SqGYVV9f+571u0432AXVQXLuBMbDhvCiT4X9D01dS1JHDtutOGxNfMLLSwzSqs6NaAvTjkVg0c94A33k4ellHrl3rz7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BY1PR0701MB1723;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1723; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(479174004)(164054003)(199003)(24454002)(377454003)(189002)(76176999)(92566002)(65816999)(42186005)(87976001)(68736005)(50466002)(62966003)(83506001)(54356999)(50986999)(77096005)(64126003)(101416001)(2351001)(19580405001)(23756003)(5001830100001)(110136002)(80316001)(33656002)(5001960100002)(69596002)(189998001)(77156002)(105586002)(5001860100001)(19580395003)(87266999)(46102003)(66066001)(59896002)(106356001)(53416004)(2950100001)(40100003)(5007970100001)(36756003)(97736004)(4001350100001)(4001540100001)(5004730100002)(47776003)(65956001)(65806001)(81156007)(64706001)(122386002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1723;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BY1PR0701MB1723;23:NzCl6SF146xPH76gb2NpSfixFiAYksRqNPAEs?= =?iso-8859-1?Q?r+uaE5i2pow0s4xDVfppL/HTT4RjlyUQEAbELttB44ebJzhnjBbdaS9HP7?= =?iso-8859-1?Q?agFHoXqCRonhZYH6B3X/Z75zJXY+FqEBcWgKlh6kcl8LLRZo8dapjISjci?= =?iso-8859-1?Q?/yJjMjTEOic8QdG/9zkn84TpOwTH/vOyve6iIgqwikE4qyVy9OvrM0bbhJ?= =?iso-8859-1?Q?rOQkwRo5ImNzh/fhmLqz1HdXReq9/8KOphx41SbhsO8I8GQY/Og27/r4Zs?= =?iso-8859-1?Q?1/yMHzddhK99mjfB5No/E9oUMIabOEMEkdrF0SdjEhf0UaBRYgVKm4xEYM?= =?iso-8859-1?Q?jPULyNH4Hb7hm0n0VCP5jTHhrPcfLz8NUXmV3yA/zEHPys4E3vB2iXyH5W?= =?iso-8859-1?Q?c1MF3Ffk2xxeKbas95qN/T2kgTZw6HnxhdrxyhMhBKHxs34Td/wWMSsGll?= =?iso-8859-1?Q?7sx9FoDUnQSKwvu86j4w157VB3Ds87t8iEqaiuNA3w5/374TIg/8xosHlI?= =?iso-8859-1?Q?FZYq/KJ0QOwj94qRfpscEOnXbA6xYoTPWo4CbS9Kt/r108xCXNoYmLH2XY?= =?iso-8859-1?Q?V9aaLOC59o9yAH2SJUwHa1uSufK6dio4NIlFbIZZH6RmMf4yputoCgGUkd?= =?iso-8859-1?Q?FlMyZBiwizIFVVxKtY28N2tglhdQ3wZIocyX6FwZrbh/O5WR4Ms2CD6zAF?= =?iso-8859-1?Q?F6RYHT+nThI8A3F8yy1QcpeIUUBITZWLfbWbgVasX+UE4MD2O6K45biMqK?= =?iso-8859-1?Q?zFRfL/ueHRx5Sfkb2ct12OKWyuK6b+JmJQ5SE6M1RvJBA1X7VQtTqJgj0q?= =?iso-8859-1?Q?ZPWPJM7h6o6uIUsAH4CFpwCm/zWkA6/1TV/ZRqi7U5seRGrHyS565lCQJQ?= =?iso-8859-1?Q?4EY/Vo1BFPLOmD3xMfH5a7pH//+13e0GXToYqcg0PjuwVfgsOwNJSv8gyX?= =?iso-8859-1?Q?2Dah89iVkhZh9q+tQzwzqmYQEyT2sJymYX9dRQuMRua5a6R0i39xotXxO1?= =?iso-8859-1?Q?zo+VPLYUwtHuX2oKHfrxOSJY5L0bJhpnB8MIBYpz/U9R9aqfPbMXjSQIfY?= =?iso-8859-1?Q?/s/ZJqEEaX86SDDDZJgJaaYKgM9bIDbk/omE/lwmp9oasbqmQK8PYd6GDi?= =?iso-8859-1?Q?Gxdnc2oEpskgZnOp9WkzWBjpHB6WfirFncrVISfCzIGLLGMNlhmD+gjUY2?= =?iso-8859-1?Q?XDnGreluBDw9nb9WOY+HPr7JtS5TNl5jFz8Jew/cJkyeGNlvURZMb6EvWH?= =?iso-8859-1?Q?Ye5ErrhajEzA5eZ8YJgEQZDnQSlxByD4+6V2EDlvU9nu5qYST3Ay7gWdDI?= =?iso-8859-1?Q?CkdS2dAgpczH5+Jm7TOVLk0nsdXkb7avnchEo7VoacYhcKrO5/3Qb6Gt9C?= =?iso-8859-1?Q?04U3zw7W9peJ8lEzzHby8xw0CjiuRONZl4CaKbOfhs3Me648PxZyzaSOe9?= =?iso-8859-1?Q?KWCpLb5fhvsz8m2Tp/A5EpPbWmqIGuSt2rDoxZpK9aP0PPiv5qHDzdja5f?= =?iso-8859-1?Q?RpL36nP/03iMe0lFIWQQ9k=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1723;5:CuUIxwADW+GbneVKucjppoklDwo/dL/HvwtNTHdCmlnnb3mm4aVwDiBX7sohs50sDB0B1nT1wf3fk++esvhdc0AuPaHgogKK/L71MRZK2GPJy0/4Vscnb/rgM5FjRagwRm0VO5SpzAwVcQgPvknDgg==;24:tnQKtWaM8MXNRBzWiMOPlyk8LnR9DENXNL402cvSeRg6sC1Si1sDEWLSh4tw8vPe6AbpbqECQxEANf35K1OtTA598iLiuim0f4uf9TSoll8=;20:ief5JH1Nn2kZ5OSjqMNpwI4dzwf/jywj9YyRXFbZRYq6sbh9PYuUYMj9dnLD3XrAcHpF0yRpYRhSfNLEDXTIkQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2015 17:53:09.6464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1723 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2015 10:44 AM, Frank Rowand wrote: > Second attempt at this reply. The first reply was mangled. > > On 9/8/2015 11:28 AM, David Daney wrote: >> From: David Daney >> >> It is perfectly legitimate for a PCI device to have an >> PCI_INTERRUPT_PIN value of zero. This happens if the device doesn't >> use interrupts, or on PCIe devices, where only MSI/MSI-X are >> supported. >> >> Silence the annoying "of_irq_parse_pci() failed with rc=-19" error >> messages by moving the printing code into of_irq_parse_pci(), and only >> emitting the message for cases where PCI_INTERRUPT_PIN == 0 is not the >> cause for an early exit. >> >> Signed-off-by: David Daney >> --- >> Changes in v2: Move the print function in to of_irq_parse_pci() at a >> common error exit point (as suggested by Frank Rowand). >> >> [...] >> @@ -87,6 +89,9 @@ int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq >> laddr[0] = cpu_to_be32((pdev->bus->number << 16) | (pdev->devfn << 8)); >> laddr[1] = laddr[2] = cpu_to_be32(0); > >> return of_irq_parse_raw(laddr, out_irq); > > should be: > > rc = of_irq_parse_raw(laddr, out_irq); > if (rc) > goto err; > return 0; > You are right. I will send v3. Thanks, David Daney >> +err: >> + dev_err(&pdev->dev, "of_irq_parse_pci() failed with rc=%d\n", rc); >> + return rc;