From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for 4.6 v2 3/3] xl/libxl: disallow saving a guest with vNUMA configured Date: Wed, 9 Sep 2015 19:49:16 +0100 Message-ID: <55F07F2C.6050803@citrix.com> References: <1441818218-5414-1-git-send-email-wei.liu2@citrix.com> <1441818218-5414-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZZkQp-0002kP-9T for xen-devel@lists.xenproject.org; Wed, 09 Sep 2015 18:49:19 +0000 In-Reply-To: <1441818218-5414-4-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 09/09/15 18:03, Wei Liu wrote: > This is due to migration v2 frame record doesn't contain node > information. This isn't a migration v2 bug, and it was similarly non-functional with legacy migration. It was yet another oversight with the vNUMA work. Isn't this information available in the domain configuration for the domain sent in the xl header? (That layer violation also need removing). Finally, your phrasing is somewhat unclear. I would recommend "The migration stream does not preserve node information" as a clearer alternative. ~Andrew