From: "Noralf Trønnes" <noralf@tronnes.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: fbtft: use pr_fmt
Date: Wed, 9 Sep 2015 23:20:08 +0200 [thread overview]
Message-ID: <55F0A288.10206@tronnes.org> (raw)
In-Reply-To: <20150909183526.GA15171@kroah.com>
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
> On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
>> Instead of defining DRVNAME and using it in all calls to pr_* family of
>> macros lets start using pr_fmt.
>>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
>> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++--------------------
>> 1 file changed, 35 insertions(+), 44 deletions(-)
[...]
> If a driver is working properly, nothing should show up in the kernel
> log at all, otherwise it's just noise that everyone ignores.
This isn't a device driver, it's a module for adding "fbtft" devices
(spi/platform with pdata). When I created fbtft, the Raspberry Pi didn't
have Device Tree support, so I made this module as a way for the end user
to add devices without having to build a kernel.
I haven't seen any module like this in the kernel, so maybe it really
doesn't
belong here at all?
Noralf.
next prev parent reply other threads:[~2015-09-09 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 13:43 [PATCH 1/3] staging: fbtft: use strncpy instead of strcpy Sudip Mukherjee
2015-09-05 13:43 ` [PATCH 2/3] staging: fbtft: do not use magic numbers Sudip Mukherjee
2015-09-05 13:43 ` [PATCH 3/3] staging: fbtft: use pr_fmt Sudip Mukherjee
2015-09-09 18:35 ` Greg Kroah-Hartman
2015-09-09 21:20 ` Noralf Trønnes [this message]
2015-09-10 4:54 ` Sudip Mukherjee
2015-09-10 16:45 ` Noralf Trønnes
2015-09-11 10:38 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F0A288.10206@tronnes.org \
--to=noralf@tronnes.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.