All of lore.kernel.org
 help / color / mirror / Atom feed
From: poma <pomidorabelisima@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com, m8t@gandi.net,
	benedikt.meurer@unix-ag.uni-siegen.de, bernhard.walle@gmx.de,
	hscholz@raisdorf.net, frivoal@xfce.org
Subject: Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.
Date: Thu, 10 Sep 2015 02:38:13 +0200	[thread overview]
Message-ID: <55F0D0F5.7060908@gmail.com> (raw)
In-Reply-To: <20150909.120405.378304490596297372.davem@davemloft.net>

On 09.09.2015 21:04, David Miller wrote:
> From: poma <pomidorabelisima@gmail.com>
> Date: Wed, 9 Sep 2015 20:34:36 +0200
> 
>> [  230.110233]  [<ffffffff810218e6>] dma_generic_alloc_coherent+0x96/0x130
>> [  230.110242]  [<ffffffff81069865>] x86_swiotlb_alloc_coherent+0x25/0x50
>> [  230.110250]  [<ffffffff810215fd>] dma_alloc_attrs+0x6d/0xe0
>> [  230.110265]  [<ffffffffa002e25e>] rtl8169_map_counters+0x3e/0x70 [r8169]
>> [  230.110277]  [<ffffffffa002f674>] rtl8169_update_counters+0x64/0x140 [r8169]
>> [  230.110289]  [<ffffffffa002f8ff>] rtl8169_get_stats64+0xbf/0x130 [r8169]
>> [  230.110299]  [<ffffffff81700b74>] dev_get_stats+0x54/0x100
> 
> The patch in question removes this call to dma_alloc_coherent() so you
> aren't running a kernel which actually has the patch applied.
> 

Here is the obvious example - in use is what is patched:

$ grep MODULE_DESCRIPTION rpmbuild/BUILD/kernel-4.2.fc24/linux-4.3.0-0.rc0.git9.1.fc24.x86_64/drivers/net/ethernet/realtek/r8169.c
MODULE_DESCRIPTION("RealTek RTL-8169 Gigabit Ethernet driver patched with [PATCH v2] r8169: Fix sleeping function called during get_stats64");

$ modinfo -n r8169; modinfo -d r8169
/lib/modules/4.3.0-0.rc0.git9.1.fc24.x86_64/updates/r8169.ko
RealTek RTL-8169 Gigabit Ethernet driver patched with [PATCH v2] r8169: Fix sleeping function called during get_stats64

  reply	other threads:[~2015-09-10  0:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 14:05 BUG: sleeping function called from invalid context at mm/page_alloc.c:3186 poma
2015-09-04 18:36 ` David Miller
2015-09-04 20:59   ` [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval Francois Romieu
2015-09-04 22:22     ` David Miller
2015-09-04 23:11       ` Francois Romieu
2015-09-04 23:15         ` David Miller
2015-09-06 10:19     ` Corinna Vinschen
2015-09-06 20:20       ` Francois Romieu
2015-09-07  7:13       ` poma
2015-09-07  8:50         ` Corinna Vinschen
2015-09-07 14:43           ` poma
2015-09-08  6:36             ` poma
2015-09-09 15:24               ` poma
2015-09-09 15:54                 ` Corinna Vinschen
2015-09-09 15:55                   ` Corinna Vinschen
2015-09-09 18:34                     ` poma
2015-09-09 19:04                       ` David Miller
2015-09-10  0:38                         ` poma [this message]
2015-09-09 19:08                       ` Corinna Vinschen
2015-09-09 23:11                         ` poma
2015-09-09 23:51                           ` poma
2015-09-10  8:47                             ` Corinna Vinschen
2015-09-10 12:36                               ` poma
2015-09-10 14:29                                 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F0D0F5.7060908@gmail.com \
    --to=pomidorabelisima@gmail.com \
    --cc=benedikt.meurer@unix-ag.uni-siegen.de \
    --cc=bernhard.walle@gmx.de \
    --cc=davem@davemloft.net \
    --cc=frivoal@xfce.org \
    --cc=hscholz@raisdorf.net \
    --cc=m8t@gandi.net \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.