All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>, tom@herbertland.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg
Date: Wed, 9 Sep 2015 21:32:30 -0600	[thread overview]
Message-ID: <55F0F9CE.30307@cumulusnetworks.com> (raw)
In-Reply-To: <20150909.202026.215174674574675091.davem@davemloft.net>

On 9/9/15 9:20 PM, David Miller wrote:
> From: Tom Herbert <tom@herbertland.com>
> Date: Wed, 9 Sep 2015 17:51:19 -0700
>
>> Consider that ip_local_out_sk calls netfilter NF_INET_LOCAL_OUT hook
>> before dst->output, so then netfilter would start seeing packets
>> with zero source address???
>
> I have to agree with Tom here, this is fatal.
>

Ok. I will drop this topic for 4.3; revisit for 4.4.

David

  reply	other threads:[~2015-09-10  3:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 21:57 [PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key David Ahern
2015-09-09 21:57 ` [PATCH 2/2 v2] net: Remove VRF change to udp_sendmsg David Ahern
2015-09-10  0:04   ` Tom Herbert
2015-09-10  0:23     ` David Ahern
2015-09-10  0:51       ` Tom Herbert
2015-09-10  1:10         ` David Ahern
2015-09-10  3:20         ` David Miller
2015-09-10  3:32           ` David Ahern [this message]
2015-09-09 22:56 ` [PATCH net-next 1/2] net: Refactor path selection in __ip_route_output_key David Ahern
2015-09-10  0:00   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F0F9CE.30307@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.