From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>,
Malcolm Crossley <malcolm.crossley@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
IanJackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/domctl: lower loglevel of XEN_DOMCTL_memory_mapping
Date: Thu, 10 Sep 2015 13:28:32 +0800 [thread overview]
Message-ID: <55F11500.10909@intel.com> (raw)
In-Reply-To: <55F0700B02000078000A1658@prv-mh.provo.novell.com>
>> If the 64 limit was arbitrary then I would suggest increasing it to at least
>> 1024 so that
>> at least 4M of BAR can be mapped in one go and it reduces the overhead by a
>> factor of 16.
>
> 1024 may be a little much, but 256 is certainly a possibility, plus
> Konrad's suggestion to allow this limit to be controlled via command
> line option.
Are you guys talking this way?
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 3946e4c..a9671bb 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -88,6 +88,10 @@ boolean_param("noapic", skip_ioapic_setup);
s8 __read_mostly xen_cpuidle = -1;
boolean_param("cpuidle", xen_cpuidle);
+/* once_mapping_mfns: memory mapping mfn bumbers once. */
+unsigned int xen_once_mapping_mfns;
+integer_param("once_mapping_mfns", xen_once_mapping_mfns);
+
#ifndef NDEBUG
unsigned long __initdata highmem_start;
size_param("highmem-start", highmem_start);
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 3bf39f1..82c85e3 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -33,6 +33,8 @@
#include <public/domctl.h>
#include <xsm/xsm.h>
+extern unsigned int xen_once_mapping_mfns;
+
static DEFINE_SPINLOCK(domctl_lock);
DEFINE_SPINLOCK(vcpu_alloc_lock);
@@ -1035,7 +1037,7 @@ long
do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
ret = -E2BIG;
/* Must break hypercall up as this could take a while. */
- if ( nr_mfns > 64 )
+ if ( nr_mfns > xen_once_mapping_mfns )
break;
ret = -EPERM;
Thanks
Tiejun
next prev parent reply other threads:[~2015-09-10 5:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 6:50 [PATCH] xen/domctl: lower loglevel of XEN_DOMCTL_memory_mapping Tiejun Chen
2015-09-09 14:20 ` Konrad Rzeszutek Wilk
2015-09-09 14:33 ` Jan Beulich
2015-09-09 14:50 ` Konrad Rzeszutek Wilk
2015-09-09 14:55 ` Jan Beulich
2015-09-09 15:05 ` Konrad Rzeszutek Wilk
2015-09-09 15:19 ` Malcolm Crossley
2015-09-09 15:44 ` Jan Beulich
2015-09-10 5:28 ` Chen, Tiejun [this message]
2015-09-10 8:13 ` Jan Beulich
2015-09-10 8:55 ` Chen, Tiejun
2015-09-10 8:59 ` Jan Beulich
2015-09-10 17:55 ` Konrad Rzeszutek Wilk
2015-09-11 0:44 ` Chen, Tiejun
2015-09-11 0:59 ` Konrad Rzeszutek Wilk
2015-09-11 9:17 ` Jan Beulich
2015-09-11 10:28 ` Malcolm Crossley
2015-09-11 11:11 ` Jan Beulich
2015-09-11 12:05 ` Malcolm Crossley
2015-09-11 14:11 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F11500.10909@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=malcolm.crossley@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.