Re: [PATCH v2 2/2] Allwinner SoC CAN controller Support

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On 09/10/2015 10:29 AM, Mirza Krak wrote:
> 2015-09-10 10:17 GMT+02:00 Marc Kleine-Budde <mkl@pengutronix.de>:
>> On 09/10/2015 08:29 AM, Gerhard Bertelsmann wrote:
>>>>> +
>>>>> +static struct platform_driver sunxi_can_driver = {
>>>>> +   .driver = {
>>>>> +              .name = DRV_NAME,
>>>>
>>>> Please remove the .name.
>>>
>>> Without it, the kernel oops
>>
>> Doh! But there was one assignment here, that was not needed...I'll try
>> to remember which one it was.
>>
> 
> I believe
> 
>     .owner = THIS_MODULE,
> 
> is not needed.

Makes sense.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]