All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: emil.l.velikov@gmail.com, Rob Clark <robclark@freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	Daniel Stone <daniels@collabora.com>
Subject: Re: [PATCH libdrm 2/2] xf86drmMode: smoke-test the atomic API
Date: Thu, 10 Sep 2015 12:10:50 +0100	[thread overview]
Message-ID: <55F1653A.90306@gmail.com> (raw)
In-Reply-To: <20150907130641.GZ29811@intel.com>

On 07/09/15 14:06, Ville Syrjälä wrote:
> On Mon, Sep 07, 2015 at 10:53:06AM +0100, Emil Velikov wrote:
>> As going through the modetest patches for atomic support I've noticed
>> that if we pass NULL for the drmModeAtomicReqPtr argument we'll crash.
>>
>> So let's handle things appropriately if the user forgot to check the
>> return value of drmModeAtomicAlloc and drmModeAtomicDuplicate or made a
>> typo somewhere along the way.
> 
> I'm not sure hand-holding the user to such an extent is actually useful.
From what I've gathered "smoke-testing" is not meant to be smart.

> OTOH I guess one NULL check per function call isn't all that expensive
> either.
> 
This is pretty much the reason why I bothered :)

Although if anyone feels strongly against it I'll drop the patch.

Thanks
Emil

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2015-09-10 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  9:53 [PATCH libdrm 1/2] automake: set --enable-valgrind during make distcheck Emil Velikov
2015-09-07  9:53 ` [PATCH libdrm 2/2] xf86drmMode: smoke-test the atomic API Emil Velikov
2015-09-07 13:06   ` Ville Syrjälä
2015-09-10 11:10     ` Emil Velikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F1653A.90306@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robclark@freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.