Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

On 09/10/2015 07:32 AM, Markus Armbruster wrote:
> This is particularly useful when we abort in error_propagate(),
> because there the stack backtrace doesn't lead to where the error was
> created.  Looks like this:
> 
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---

Already in mainline, but I'm wondering...


> +++ b/util/error.c
> @@ -18,12 +18,23 @@ struct Error
>  {
>      char *msg;
>      ErrorClass err_class;
> +    const char *src, *func;
> +    int line;
>  };
>  

Should we also be modifying error_copy() to propagate source information
into the copy?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]