All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared branches
Date: Thu, 10 Sep 2015 19:34:05 +0300	[thread overview]
Message-ID: <55F1B0FD.4050406@linaro.org> (raw)
In-Reply-To: <20150909224613.GW15099@codeaurora.org>

On 09/10/2015 01:46 AM, Stephen Boyd wrote:
> On 08/13, Georgi Djakov wrote:
[..]
>> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
>> index 9aec1761fd29..681faf2dcdc5 100644
>> --- a/drivers/clk/qcom/clk-rcg2.c
>> +++ b/drivers/clk/qcom/clk-rcg2.c
>> +
>> +static int clk_rcg2_shared_enable(struct clk_hw *hw)
>> +{
>> +	struct clk_rcg2 *rcg = to_clk_rcg2(hw);
>> +	const char *name = clk_hw_get_name(hw);
>> +
>> +	if (!rcg->current_freq) {
>> +		pr_err("%s: Please set rate before enabling\n", name);
> 
> Why? Can't we find the current freq during recalc_rate?
> 

Yes, thank you!


  reply	other threads:[~2015-09-10 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 14:48 [PATCH v3 0/5] Add support for more MSM8916 clocks Georgi Djakov
2015-08-13 14:48 ` [PATCH v3 1/4] clk: qcom: Add MSM8916 iommu clocks Georgi Djakov
2015-08-13 14:48 ` [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared branches Georgi Djakov
2015-09-09 22:46   ` Stephen Boyd
2015-09-10 16:34     ` Georgi Djakov [this message]
2015-08-13 14:48 ` [PATCH v3 3/4] clk: qcom: Add MSM8916 gpu clocks Georgi Djakov
2015-08-13 14:48 ` [PATCH v3 4/4] clk: qcom: Add MSM8916 audio clocks Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F1B0FD.4050406@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.